Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add normalization_resolver to resolve normalization layers #4926

Merged
merged 6 commits into from
Jul 7, 2022

Conversation

lightaime
Copy link
Contributor

This pull request adds the normalization_resolver to support resolving normalization layers, which provides a flexible way to choose normalization layers in GNNs.

@codecov
Copy link

codecov bot commented Jul 6, 2022

Codecov Report

Merging #4926 (a608932) into master (02a7026) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #4926   +/-   ##
=======================================
  Coverage   82.70%   82.71%           
=======================================
  Files         330      330           
  Lines       17850    17857    +7     
=======================================
+ Hits        14763    14770    +7     
  Misses       3087     3087           
Impacted Files Coverage Δ
torch_geometric/nn/resolver.py 88.00% <100.00%> (+1.95%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02a7026...a608932. Read the comment docs.

@lightaime lightaime marked this pull request as ready for review July 6, 2022 19:32
Copy link
Member

@rusty1s rusty1s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

test/nn/test_resolver.py Outdated Show resolved Hide resolved
test/nn/test_resolver.py Outdated Show resolved Hide resolved
@rusty1s rusty1s merged commit 31866b5 into master Jul 7, 2022
@rusty1s rusty1s deleted the normalization_resolver branch July 7, 2022 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants