Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lightning Trainer integration in GraphGym #4689

Merged
merged 23 commits into from
May 30, 2022

Conversation

aniketmaurya
Copy link
Contributor

Third PR from the Roadmap.

  • Implements PL Trainer
  • Soft import for optional dependencies
  • Update tests

@codecov
Copy link

codecov bot commented May 20, 2022

Codecov Report

Merging #4689 (94ab45d) into master (70a3760) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4689      +/-   ##
==========================================
- Coverage   82.43%   82.39%   -0.04%     
==========================================
  Files         322      323       +1     
  Lines       17237    17215      -22     
==========================================
- Hits        14209    14184      -25     
- Misses       3028     3031       +3     
Impacted Files Coverage Δ
torch_geometric/graphgym/config.py 95.04% <ø> (-0.03%) ⬇️
torch_geometric/graphgym/imports.py 100.00% <100.00%> (ø)
torch_geometric/graphgym/logger.py 84.61% <100.00%> (+2.75%) ⬆️
torch_geometric/graphgym/model_builder.py 98.14% <100.00%> (-0.04%) ⬇️
torch_geometric/graphgym/train.py 100.00% <100.00%> (+1.78%) ⬆️
torch_geometric/graphgym/utils/agg_runs.py 46.54% <100.00%> (ø)
torch_geometric/graphgym/utils/epoch.py 57.14% <0.00%> (-42.86%) ⬇️
torch_geometric/graphgym/checkpoint.py 38.29% <0.00%> (-42.56%) ⬇️
torch_geometric/data/lightning_datamodule.py 38.26% <0.00%> (+12.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70a3760...94ab45d. Read the comment docs.

graphgym/main.py Outdated Show resolved Hide resolved
torch_geometric/graphgym/utils/agg_runs.py Show resolved Hide resolved
Copy link
Member

@rusty1s rusty1s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is amazingly clean. Thank you so much! I love it :)

test/graphgym/test_graphgym.py Outdated Show resolved Hide resolved
torch_geometric/graphgym/model_builder.py Show resolved Hide resolved
torch_geometric/graphgym/train.py Outdated Show resolved Hide resolved
torch_geometric/graphgym/utils/agg_runs.py Show resolved Hide resolved
@rusty1s rusty1s changed the title Lightning Trainer integration Lightning Trainer integration in GraphGym May 30, 2022
@rusty1s rusty1s merged commit 5a4f868 into pyg-team:master May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants