Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HeteroConv does not support add_self_loop models #4646

Closed
Padarn opened this issue May 15, 2022 · 1 comment
Closed

HeteroConv does not support add_self_loop models #4646

Padarn opened this issue May 15, 2022 · 1 comment

Comments

@Padarn
Copy link
Contributor

Padarn commented May 15, 2022

🐛 Describe the bug

Brought up by @rusty1s in the discussion here, it was noted that when using a HetreoConv model with relationship models that use add_self_loops the message passing will be incorrect. For example:

HeteroConv({('A', 'to', 'B'): GATConv((-1, -1), hidden_channels, heads=4, dropout=0.2)})

This is caused by the fact that the self loops would then refer links between source and destination nodes of different types.

The suggestion here is to add a check inside HeteroConv that would warn raise an exception to avoid users unknowingly doing this.

@Padarn Padarn added the bug label May 15, 2022
@Padarn Padarn self-assigned this May 15, 2022
@rusty1s rusty1s changed the title HetroConv does not support add_self_loop models HeteroConv does not support add_self_loop models May 15, 2022
@rusty1s
Copy link
Member

rusty1s commented May 15, 2022

Can we do the same for to_hetero()?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants