Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vehement role bonus isn't applying #668

Closed
ftsartek opened this issue Jul 2, 2016 · 2 comments
Closed

Vehement role bonus isn't applying #668

ftsartek opened this issue Jul 2, 2016 · 2 comments
Labels
bug Confirmed to be a bug fixed This issue has been fixed! Oh joy!

Comments

@ftsartek
Copy link
Contributor

ftsartek commented Jul 2, 2016

When attempting to see the DPS difference between the Moros and Vehement, the 37.5% damage role bonus doesn't appear to apply:

3x Damage mods, 3x T2 HAW w/ Void XL, T2 Siege
Vehement: http://puu.sh/pNrrF/ea91ef49d6.png
Moros: http://puu.sh/pNrsh/b75a2dd8e1.png

0 Damage mods, 1x T2 HAW w/ Void XL, No Siege
Vehement: http://puu.sh/pNvPm/23cdaeab75.png
Moros: http://puu.sh/pNvQh/48643be3fd.png

Moros on left, Vehement on right (Ebag took these screenshots)
http://puu.sh/pNtTQ/3ce13d675b.png
http://puu.sh/pNtMV/8318735686.png

This is seemingly reproducable.

@Ebag333
Copy link
Contributor

Ebag333 commented Jul 2, 2016

With 0 skills, and a very simple fit (T1 blaster with iron, no DPS mods), I would expect Vehement to have more DPS due to the role bonus. Instead they both have the exact same DPS.

I took a quick peek at it, the ship shows that the role is applied, and the role gets run (with the correct damage modifier), but it doesn't show up as an applied modifier on the gun itself.

@Ebag333
Copy link
Contributor

Ebag333 commented Jul 2, 2016

#669

Pull request submitted to fix issue.

@blitzmann blitzmann added bug Confirmed to be a bug fixed This issue has been fixed! Oh joy! labels Jul 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed to be a bug fixed This issue has been fixed! Oh joy!
Projects
None yet
Development

No branches or pull requests

3 participants