Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty ECCM and Sensor Backup Arrays groups in item browser #546

Closed
MrNukealizer opened this issue Mar 25, 2016 · 8 comments
Closed

Empty ECCM and Sensor Backup Arrays groups in item browser #546

MrNukealizer opened this issue Mar 25, 2016 · 8 comments
Labels
bug Confirmed to be a bug fixed This issue has been fixed! Oh joy!

Comments

@MrNukealizer
Copy link
Contributor

The categories for the various types of ECCM are still there even though there's only one module in any of them. It's probably a bug that the 'Shady' Sensor Booster is still listed under ECCM in game, so that will likely change soon and mean the end of the ECCM category..

@MrNukealizer MrNukealizer changed the title Empty ECCM groups in item browser Empty ECCM and Sensor Backup Arrays groups in item browser Mar 25, 2016
@MrNukealizer
Copy link
Contributor Author

Also the Sensor Backup Arrays categories are empty except for the 'Firewall' Signal Amplifier.

@blitzmann
Copy link
Collaborator

That's all sourced from the EVE data. I can look into disabling them manually, but CCP will (hopefully) clean them up eventually

@blitzmann
Copy link
Collaborator

I just checked on SISI and these market groups dont show up. So I'm not sure if it's an issue in pyfa or if the data was patched with sisi. I can take a look at this more closely later

@MrNukealizer
Copy link
Contributor Author

Someone probably noticed when adding the new capital and citadel stuff. It'll probably be fixed on TQ when the update comes out.

@MrNukealizer
Copy link
Contributor Author

Well as of the current version the categories still show up but are empty.

@blitzmann
Copy link
Collaborator

blitzmann commented May 1, 2016

Thanks for pointing that out. I figured before it was just CCP forgetting to remove them, but actually looking into this: we are sourcing data from a resource that does not specify hasTypes for market groups, which would normally tell us if we have any items at all under that group. I don't know when this changed and how long pyfa has been improper due to it, but I will look into it soonish. AS of right now, it's not a major concern though.

@blitzmann blitzmann added the bug Confirmed to be a bug label May 1, 2016
@blitzmann
Copy link
Collaborator

I kinda of fixed this by using data from the cache that has the hasType properties. There's still a bug that causes ECCM to show up, but at least it no longer has any children.

@blitzmann blitzmann added the fixed This issue has been fixed! Oh joy! label May 1, 2016
@blitzmann
Copy link
Collaborator

Have to manually remove the ECCM market group.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed to be a bug fixed This issue has been fixed! Oh joy!
Projects
None yet
Development

No branches or pull requests

2 participants