Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dual prop enabled at the same time on import #522

Closed
geoff-kruss opened this issue Feb 17, 2016 · 1 comment
Closed

Dual prop enabled at the same time on import #522

geoff-kruss opened this issue Feb 17, 2016 · 1 comment
Labels
duplicate Duplicate of another issue, will most likely be closed with a link to the original

Comments

@geoff-kruss
Copy link

Importing a fitting that has both an afterburner and a microwarpdrive propulsion module causes both modules to be activated simultaneously, the usual check that happens when enabling a prop mod doesn't happen on import.

I have only tested this with EFT formatted fittings and only importing via the clipboard, though I would expect that the issue would exist even if importing via some other method. I can reproduce it easily, with varying ship and module combinations.

In addition, the calculated velocity for the ship appears to take the base velocity, plus the percentage modifier of whichever prop mod is in the higher position, and then applies the next modifier on top of this new total creating really silly looking speeds.

pyfa 1.18.0 - this is where I initially spotted the issue
pyfa 1.19.1 - tested, bug still exists

Only able to test on Windows 10.

Thanks

EDIT: Perhaps a solution would be to pick whichever module is in the highest slot and enable that ? Or leave both disabled...

EDIT: In issue #512 there is talk of working on validation during import, so this is more than likely related.

@blitzmann
Copy link
Collaborator

You are correct with your edit, this seems to be a duplicate of #512. Hopefully I can get around to fixing this before the next release in March - it should be really simple.

@blitzmann blitzmann added the duplicate Duplicate of another issue, will most likely be closed with a link to the original label Feb 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate Duplicate of another issue, will most likely be closed with a link to the original
Projects
None yet
Development

No branches or pull requests

2 participants