Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Damage graph doesn't consider sentry tracking/falloff #511

Closed
mmaucher opened this issue Jan 25, 2016 · 4 comments
Closed

Damage graph doesn't consider sentry tracking/falloff #511

mmaucher opened this issue Jan 25, 2016 · 4 comments
Labels
bug Confirmed to be a bug fixed This issue has been fixed! Oh joy!

Comments

@mmaucher
Copy link

Since a recent patch, there's just a flat line for damage done by sentry drones, independent from distance or target's signature radius or radial velocity.
Please bring back the old damage graph for sentry drones.

@blitzmann
Copy link
Collaborator

You said since a recent patch its been broken. Do you know when this was caused? I don't think anybody has touched the graphing code for a while

@mmaucher
Copy link
Author

After checking out 52d19b8 (last commit 2016-01-09), the graphs seem to show the correct DPS.
After checking out 36ab224 (v1.18.0), the graphs are broken.

@blitzmann
Copy link
Collaborator

Thanks. I'll have to double check, but if true, then that means there was a change in the EVE data regarding sentries, because nothing happened between those commits besides updating data.

Will look into it when I can. Can you in the meantime provide a quick test fit, along with possibly graphs showing expected plotting vs current plotting?

@mmaucher
Copy link
Author

As a test fit, a Tristan with a single Garde I should suffice:
[Tristan, AAA]
Garde I x1

I've attached 4 graphs, showing the corresponding dps graphs against a target with and without angular velocity.
Graph 1: Expected output, no angular movement
Graph 2: Expected output, with angular movement
Graph 3: Current output, no angular movement
Graph 4: Current output, with angular movement

expected_0_degrees
expected_90_degrees
current_0_degrees
current_90_degrees

@blitzmann blitzmann added bug Confirmed to be a bug fixed This issue has been fixed! Oh joy! labels May 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Confirmed to be a bug fixed This issue has been fixed! Oh joy!
Projects
None yet
Development

No branches or pull requests

2 participants