-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pyfa exit stops responding after silent Crest API issue #450
Comments
Error handling for CREST is unfortunately non-existent, and it's something I want to fix at some point after the OSX build are stabilized (see #383). The message displayed in the browser is simply an acknowledgement that the server got a response, rather than a successful response The response seems to have been a 503, which I guess may happen if the EVE server is down. Unless you can consistently reproduce it, in which case I want you to reproduce with the debug flag and post the output. The traceback is interesting though... Did you have the Export to eve dialog open at some point before this? |
Sorry, looks like a pasted the same traceback twice above. I'm editing it and showing below there were different tracebacks during the Pyfa instance I ran last night.
|
I'll look into this, but it seems it's just not handling a response correctly and thus throwing errors everywhere. Let me know if you can reproduce it and post the debug logs - that would help in determining where in the logic this is happening at. |
I noticed that I can close Pyfa gracefully each time except if I Crest login first. Here I just opened Pyfa and exited after Crest login without doing anything else and the process stopped responding after closing the GUI. Had to ^Z to get back to terminal prompt and the process was even then still running.
That's on preRelease, but I get the same results on 1.16.2 |
Got a debug log during an API issue period, though it was a different code this time (502 vs 503)
If I wait 60 seconds before trying to exit the app, I get an additional timeout message, then exiting causes stopped responding. |
@thorr18 is this still a thing? I don't remember if I ever got any headway into this. From the logs posted, these all seem like it gets a bad status from the EVE servers. I've tried to test with a known back endpoint (returns 502) and which the traceback happens, it doesn't cause an issue with closing pyfa or anything. Then again, this is on Windows and I suspect this is a bug that revolved around os x. Let me know if you still have the issue, thx |
My apologies. Dropped off the face of the Earth. Life transition. |
I could repeatedly use the Crest Login menu option and authorize and get the "Done. Please close this window" browser message, but could not enable the Browse Eve Fit menu option. There was no message from Pyfa for user to know there was an issue. It just silently failed.
Running it again on the terminal showed a server issue.
Later, trying to exit Pyfa caused it to stop responding. Had to force close:
A few minutes later, the API issue was gone and I was able to browse Eve fits and exit Pyfa gracefully.
Testing was done with Pyfa pre-release 1.16.3 build on OSX 10.11.1
The text was updated successfully, but these errors were encountered: