Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Traceback when working with t3ds #323

Closed
DarkFenX opened this issue Jul 9, 2015 · 3 comments
Closed

Traceback when working with t3ds #323

DarkFenX opened this issue Jul 9, 2015 · 3 comments

Comments

@DarkFenX
Copy link
Member

DarkFenX commented Jul 9, 2015

Confessor:

Exception in thread Thread-2:
Traceback (most recent call last):
  File "/usr/lib/python2.7/threading.py", line 810, in __bootstrap_inner
    self.run()
  File "/home/dfx/src/eve/pyfa/service/market.py", line 75, in run
    self.processUpdates()
  File "/home/dfx/src/eve/pyfa/service/market.py", line 85, in processUpdates
    service.Price.fetchPrices(requests)
  File "/home/dfx/src/eve/pyfa/service/price.py", line 55, in fetchPrices
    if item.marketGroupID:
AttributeError: 'NoneType' object has no attribute 'marketGroupID'

Seems like it still attempts to fetch price for t3d mode? Just doesn't put item there anymore, but puts None.

@blitzmann
Copy link
Collaborator

I cannot reproduce. Returning None is the same way empty module slots handle not getting a price. In any case, doesn't make sense as the mode shouldn't be added to the price fetching queue. I think this may have something to do with the other issue you posted - #324. Something weird indeed

  • oh, I was able to reproduce when I pasted the fitting from 324 in... =/

@DarkFenX
Copy link
Member Author

DarkFenX commented Jul 9, 2015

Yeah, just make t3d fit, fit some gun to it and move it to another slot.

@blitzmann
Copy link
Collaborator

k, so I have no idea why this happens, but I committed a check to make sure item is not None. That should hopefully work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants