Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double propulsion modules speed #299

Closed
unti1x opened this issue Jun 6, 2015 · 2 comments
Closed

Double propulsion modules speed #299

unti1x opened this issue Jun 6, 2015 · 2 comments

Comments

@unti1x
Copy link

unti1x commented Jun 6, 2015

  1. Fit any propulsion module (see normal speed)
  2. Fit another one. First module turns off, but speed being recalculated using old speed with first module on. E.g. basic speed - 383 m/s; with 5mn mwd II - 2826 m/s; fit second mwd - first module turned off, but speed recalculated to 16335 m/s.

If import fitting with two propmods from clipboard, you'll have both of them turned on

@blitzmann
Copy link
Collaborator

Thanks. Helpful to note that you can toggle the props again and it will correct itself. Seems to be an oversight of checking states as the module is being loaded or run through the calculations... not sure of the order here, but I'll check it out. =)

@blitzmann
Copy link
Collaborator

Fixed. What was happening was that when appending an item from the market, pyfa would turn the new module active and then recalculate the fit (which would recalculate with 2 active MWDs). It then goes through a process of checking all module states and deactivates any disallowed modules (like the other MWD). If any changes to states occur during this, that's a flag that the fit must be recalculated again. It's this second calculation that we are missing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants