Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quickly fitting modules using shortcuts #183

Closed
lunedis opened this issue Oct 9, 2014 · 6 comments
Closed

Quickly fitting modules using shortcuts #183

lunedis opened this issue Oct 9, 2014 · 6 comments

Comments

@lunedis
Copy link
Contributor

lunedis commented Oct 9, 2014

Example procedure:

  1. Type "10mn micro" into the market search
  2. See list of possible MWDs with 1) or 2) in front of them
  3. Fit the experimenttal mwd (2nd in list) using for example "alt+2". It gets fitted to the first free medslot
  4. ctrl+a and erase search, search new item, repeat.

This allows you to fit a lot of modules really quickly, without having to use the mouse.
EFT has that feature (using CTRL+number), it's called "enable fitting shortcuts" there.

@blitzmann
Copy link
Collaborator

I like this idea, however I'm confused as to how it might work for those items that are at position #14 or whatever. Would it also be helpful to list the number along with the module? I haven't ever played with this feature in EFT so i do not know how it would function

@blitzmann
Copy link
Collaborator

I noticed that you started work on this on your own branch. I have not tried it yet, but it looks like it could be promising. If you are still interested in developing it, let me know and shoot over a pull request when ready. If you have abandoned it, I can evaluate your current progress and see if we can incorporate your changes into master.

@lunedis
Copy link
Contributor Author

lunedis commented Jul 3, 2015

I implemented it two times: first very rough to test the functionality, second time better with nicer code (with lists and stuff, whee).

The idea was basically to import the ItemSelected event from the market browser and then just copy the code from the existing shortcuts in order to connect ALT+number to the selecting the specific item in the list.

I have not done any UI changes.
Works fine though, I use it everyday.

@blitzmann
Copy link
Collaborator

I've tried your code, works fine. Feel free to submit a pull request, and maybe I can clean it up in the gui

@blitzmann
Copy link
Collaborator

You might need to apply the patches to a branch that is off the vanilla pyfa master, and use that as your pull request. Since there have been many merges since your changes, not sure if the pull request would work. Worth a shot tho =)

@blitzmann
Copy link
Collaborator

Merged, thanks! Hopefully this will be useful to others as well.

I developed a simple way to convey the shortcut in the module list. There will be a toggle to turn it on if the user finds it helpful (but default will be off):

edit: done. Closing issue.
capture

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants