Target painter not calculated in a DPS graph

[cyb34]

Fitting 2x Phased Weapon Navigation Array Generation Extron on a Raven (Arbalest Cruise Launcher I) gives no extra DPS against targets with lower signature radius.

[blitzmann]

Thanks for this. It's been reported by quite a few people in the last few weeks. Looking at the code, it seems that it completely ignores ewar effects on the target and simply calculates turret / missile damage as is.

The problem here is that we supply 4 simple values for the target, but this is NOT considered a fit in pyfa. Since it's not a fit, we cannot do a simple projection of attacker to target and get the values. Therefore, to support EWAR, we have to manually check for TPs and webs and apply them manually to the target. I'm sure this can be added with a bit of thought, tho it is not the best solution.

The best solution would be to overhaul the graphing support. Allow us to pick a fit of aggressor and target (kinda like how EFT does it). That way we can use the already included projection functions of Pyfa to easily do this. But that would require much more time. We can also look into making a blank fit with only the user-defined values for the ship attributes. I have no idea if that would even work or not.

I'll continue to look into this.

[blitzmann]

I put together something that would include target painters and webs factoring into the user-supplied values.

Graph does not consider TP or web drones. I can add these later if there is demand for them (shouldn't be too difficult), but I'd rather not patch this thing up - complete rewrite would be best option.

[cyb34]

Awesome! Thank you :)