Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Komodo's [shipbonustitang2alldamagebonus.py] should not have thermalDamage assignments #1332

Closed
oaao opened this issue Nov 2, 2017 · 1 comment
Labels
eve This issue is related to EVE data. Sometimes they fuck up too and have bugs ¯\_(ツ)_/¯ fixed This issue has been fixed! Oh joy!

Comments

@oaao
Copy link
Contributor

oaao commented Nov 2, 2017

There are currently two files that assign missile damage bonus to Komodo:

However, thermalDamage assignment exists in both, so pyfa is currently double-dipping sources for thermal XL missile damage bonus and displaying values of ~triple what they should be.

L9/10, L15/16, L23/24 should be deleted in eos/effects/shipbonustitang2alldamagebonus.py.

[e:] PR included below.

@blitzmann blitzmann added the eve This issue is related to EVE data. Sometimes they fuck up too and have bugs ¯\_(ツ)_/¯ label Nov 2, 2017
@blitzmann
Copy link
Collaborator

Hey there,

Good catch! However, this is a known issue and is actually (probably) an EVE bug as well. See #1320 (comment) for details. In hindsight, I probably shouldn't have closed that issue lol.

I can't actually confirm if this happen in-game, but according to the data directly from EVE this is the case. I have a bug report out for it without any activity on it yet - I'll give it another couple of weeks before I ping one of the devs.

As for the PR, I appreciate the fix, however I'm going to leave it be until I hear back from CCP or notice a fix deployed. It is technically a thing that happens in game, so pyfa should be accurate (again, can't test... does anyone have this ship? :P)

@blitzmann blitzmann added the fixed This issue has been fixed! Oh joy! label Nov 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
eve This issue is related to EVE data. Sometimes they fuck up too and have bugs ¯\_(ツ)_/¯ fixed This issue has been fixed! Oh joy!
Projects
None yet
Development

No branches or pull requests

2 participants