You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
However, thermalDamage assignment exists in both, so pyfa is currently double-dipping sources for thermal XL missile damage bonus and displaying values of ~triple what they should be.
Good catch! However, this is a known issue and is actually (probably) an EVE bug as well. See #1320 (comment) for details. In hindsight, I probably shouldn't have closed that issue lol.
I can't actually confirm if this happen in-game, but according to the data directly from EVE this is the case. I have a bug report out for it without any activity on it yet - I'll give it another couple of weeks before I ping one of the devs.
As for the PR, I appreciate the fix, however I'm going to leave it be until I hear back from CCP or notice a fix deployed. It is technically a thing that happens in game, so pyfa should be accurate (again, can't test... does anyone have this ship? :P)
There are currently two files that assign missile damage bonus to Komodo:
eos/effects/shipbonustitang1kinthermdamagebonus.py for kin/therm damage types (+50%), and
eos/effects/shipbonustitang2alldamagebonus.py for what should be all else (expl/EM, +40%).
However, thermalDamage assignment exists in both, so pyfa is currently double-dipping sources for thermal XL missile damage bonus and displaying values of ~triple what they should be.
L9/10, L15/16, L23/24 should be deleted in eos/effects/shipbonustitang2alldamagebonus.py.
[e:] PR included below.
The text was updated successfully, but these errors were encountered: