Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] Limit C-MOVE and C-GET to 65535 suboperations #983

Merged
merged 2 commits into from
Nov 25, 2024

Conversation

scaramallion
Copy link
Member

@scaramallion scaramallion commented Nov 25, 2024

Reference issue

Closes #982

Tasks

  • Unit tests added that reproduce issue or prove feature is working
  • Fix or feature added
  • Documentation and examples updated (if relevant)
  • Unit tests passing and coverage at 100% after adding fix/feature
  • Type annotations updated and passing with mypy

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (37ccf38) to head (ba13905).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #983   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           28        28           
  Lines         8707      8709    +2     
=========================================
+ Hits          8707      8709    +2     
Files with missing lines Coverage Δ
pynetdicom/service_class.py 100.00% <100.00%> (ø)
---- 🚨 Try these New Features:

@scaramallion scaramallion merged commit f0835cb into pydicom:main Nov 25, 2024
11 checks passed
@scaramallion scaramallion changed the title [WIP] Limit C-MOVE and C-GET to 65535 suboperations [MRG] Limit C-MOVE and C-GET to 65535 suboperations Nov 25, 2024
@scaramallion scaramallion deleted the dev-qr branch November 25, 2024 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Large number of DIMSE sub-operations leads to integer overflow
1 participant