Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

numpy 2 compatibility in the pydap backend #9391

Merged
merged 5 commits into from
Aug 22, 2024
Merged

numpy 2 compatibility in the pydap backend #9391

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1e6b2b0
re instate `pydap` to CI
Mikejmnez Aug 21, 2024
d620b39
include description on `what is new`
Mikejmnez Aug 21, 2024
3695fc8
re-instate testing pydap
Mikejmnez Aug 21, 2024
efbfc33
move whats new docs entry from `bug fixes` to `internal changes`
Mikejmnez Aug 21, 2024
286526b
Merge branch 'main' into numpy2-pydap
Mikejmnez Aug 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ci/requirements/all-but-dask.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ dependencies:
- pandas
- pint>=0.22
- pip
# - pydap
- pydap
- pytest
- pytest-cov
- pytest-env
Expand Down
2 changes: 1 addition & 1 deletion ci/requirements/environment-windows.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ dependencies:
# - pint>=0.22
- pip
- pre-commit
# - pydap
- pydap
- pytest
- pytest-cov
- pytest-env
Expand Down
2 changes: 1 addition & 1 deletion ci/requirements/environment.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ dependencies:
- pooch
- pre-commit
- pyarrow # pandas raises a deprecation warning without this, breaking doctests
# - pydap
- pydap
- pytest
- pytest-cov
- pytest-env
Expand Down
2 changes: 2 additions & 0 deletions doc/whats-new.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,8 @@ Bug fixes
- Fix issue with passing parameters to ZarrStore.open_store when opening
datatree in zarr format (:issue:`9376`, :pull:`9377`).
By `Alfonso Ladino <https://github.com/aladinor>`_
- ``numpy>=2`` compatibility in the ``pydap`` backend (:pull:`9391`).
By `Miguel Jimenez <https://github.com/Mikejmnez>`_ .
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since this doesn't expose or fix any bugs I'd move this to "internal changes" and change it to something similar to "re-enable testing pydap with numpy>=2"


Documentation
~~~~~~~~~~~~~
Expand Down
Loading