Move Variable aggregations to NamedArray

[dcherian]

• fix breaking attrs test
• Look at numeric_only in NAMED_ARRAY_OBJECT
• xref NamedArray tracking issue #8238
• Tests added

[dcherian]

re the comment: This is quite annoying.

[andersy005]

Looks solid to me 👍🏽! thank you for working on this, @dcherian

[dcherian]

Don't know how to fix these.

xarray/namedarray/core.py: note: In member "_get_axis_num" of class "NamedArray":
Generated Cobertura report: /home/runner/work/xarray/xarray/mypy_report/cobertura.xml
xarray/namedarray/core.py:353: error: Returning Any from function declared to return "int"  [no-any-return]
xarray/namedarray/core.py: note: In member "reduce" of class "NamedArray":
xarray/namedarray/core.py:476: error: Function is missing a type annotation for one or more arguments  [no-untyped-def]
xarray/core/variable.py: note: In member "reduce" of class "Variable":
xarray/core/variable.py:1707: error: Signature of "reduce" incompatible with supertype "NamedArray"  [override]
xarray/core/variable.py:1707: note:      Superclass:
xarray/core/variable.py:1707: note:          def reduce(self, func: Callable[..., Any], dim: str | Iterable[Hashable] | ellipsis | None = ..., axis: int | Sequence[int] | None = ..., keepdims: bool = ..., **kwargs: Any) -> Any
xarray/core/variable.py:1707: note:      Subclass:
xarray/core/variable.py:1707: note:          def reduce(self, func: Callable[..., Any], dim: str | Iterable[Hashable] | ellipsis | None = ..., axis: int | Sequence[int] | None = ..., keep_attrs: bool | None = ..., keepdims: bool = ..., **kwargs: Any) -> Variable

[andersy005]

@dcherian, are we okay w/ merging this as is, and fixing the typing issue in a separate pull request? i personally don't know how to address the typing issues.

[andersy005]

Cc @Illviljan for help if you happen to have time :)

[max-sixty]

are we okay w/ merging this as is, and fixing the typing issue in a separate pull request?

No strong view on fixing vs. ignoring, but I would vote quite strongly to explicitly ignore errors, rather than break the tests, since it's difficult to oversee tests whose good state is a break...

[dcherian]

I think the issue is real and tied to not having keep_attrs in NamedArray.reduce but having it in Variable.reduce.

        # Noe that the call order for Variable.mean is
        #    Variable.mean -> NamedArray.mean -> Variable.reduce
        #    -> NamedArray.reduce

One option would be to use a to_named_array and from_named_array pattern.

[dcherian]

One option would be to use a to_named_array and from_named_array pattern.

didn't work.

[Illviljan]

Is NamedArray big fans of axis inputs? I thought this was a mistake in xarray.

[dcherian]

Ah I forgot to raise this as an issue. It's definitely a mistake for Dataset. DataArray and Variable do have ordered dimensions so in principle it's OK but discouraged.