Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add benchmark against latest release on main. #7753

Merged
merged 4 commits into from
Apr 18, 2023
Merged

Add benchmark against latest release on main. #7753

merged 4 commits into from
Apr 18, 2023

Conversation

dcherian
Copy link
Contributor

This adds a benchmark of HEAD vs the latest tag on main.

@github-actions github-actions bot added the Automation Github bots, testing workflows, release automation label Apr 13, 2023
@dcherian dcherian force-pushed the benchmark-from-last-release branch from a49085a to e517c12 Compare April 13, 2023 17:35
headtr1ck
headtr1ck approved these changes Apr 15, 2023
View reviewed changes
Copy link
Collaborator

@headtr1ck headtr1ck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a really good idea to prevent accidental regressions.

Is it possible to prevent the cancelling of this run when pushing another commit to main? This would be nice to trace the regressions.
Maybe this is not so important though since bulk PR merging usually happens with smaller PRs.

I assume that a decreased performance will result in a CI fail? Maybe we could automate this even more and automatically open an issue? But that can be done in another PR.

Thanks!

@headtr1ck headtr1ck added the plan to merge Final call for comments label Apr 17, 2023
@dcherian
Copy link
Contributor Author

Is it possible to prevent the cancelling of this run when pushing another commit to main? This would be nice to trace the regressions.

I think that's the default

assume that a decreased performance will result in a CI fail? Maybe we could automate this even more and automatically open an issue?

Yeah but its a little flaky: https://labs.quansight.org/blog/github-actions-benchmarks so the noise might not be worth it

@dcherian dcherian merged commit 5cd3db5 into pydata:main Apr 18, 2023
@dcherian dcherian deleted the benchmark-from-last-release branch April 18, 2023 22:08
dcherian added a commit to dcherian/xarray that referenced this pull request Apr 25, 2023
@dcherian
Merge branch 'main' into grouper-objects
142bc69 
* main:
  Bump codecov/codecov-action from 3.1.2 to 3.1.3 (pydata#7781)
  Fix whats-new
  [skip-ci] dev whats-new (pydata#7775)
  [skip-ci] Release 2023.04.2 (pydata#7774)
  Fix groupby_bins when labels are specified (pydata#7769)
  Docstrings examples for string methods (pydata#7669)
  Add dev whats-new
  Add benchmark against latest release on main. (pydata#7753)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@headtr1ck headtr1ck headtr1ck approved these changes

Assignees
No one assigned
Labels
Automation Github bots, testing workflows, release automation plan to merge Final call for comments
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dcherian @headtr1ck