Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preserve boolean dtype in encoding #7720

Merged
merged 3 commits into from
Apr 10, 2023
Merged

Conversation

kmuehlbauer
Copy link
Contributor

@kmuehlbauer kmuehlbauer commented Apr 5, 2023

Split out of #7654. Follow up to #7719. Needs rebase after #7719 is merged.

@kmuehlbauer
Copy link
Contributor Author

kmuehlbauer commented Apr 7, 2023

Rebased on top main after merge of #7719. This is ready for review. It's a one-liner actually 😁

@headtr1ck headtr1ck added the plan to merge Final call for comments label Apr 8, 2023
@Illviljan Illviljan merged commit 5f39626 into pydata:main Apr 10, 2023
@Illviljan
Copy link
Contributor

Thanks, @kmuehlbauer !

dcherian added a commit to dcherian/xarray that referenced this pull request Apr 18, 2023
* main: (34 commits)
  Update whats-new.rst
  Fix binning by unsorted array (pydata#7762)
  Bump codecov/codecov-action from 3.1.1 to 3.1.2 (pydata#7760)
  Fix typing errors using mypy 1.2 (pydata#7752)
  [skip-ci] dev whats-new
  Add whats-new for v2023.04.0 (pydata#7757)
  remove the `black` hook (pydata#7756)
  reword the what's new entry for the `pandas` 2.0 dtype changes (pydata#7755)
  restructure the contributing guide (pydata#7681)
  Continue to use nanosecond-precision Timestamps in precision-sensitive areas (pydata#7731)
  minor doc updates to clarify extensions using accessors (pydata#7751)
  align: Avoid reindexing when join="exact" (pydata#7736)
  `pandas=2.0` support (pydata#7724)
  Clarify vectorized indexing documentation (pydata#7747)
  Avoid recasting a CFTimeIndex (pydata#7735)
  fix typo (pydata#7746)
  [pre-commit.ci] pre-commit autoupdate (pydata#7745)
  Bump pypa/gh-action-pypi-publish from 1.8.4 to 1.8.5 (pydata#7743)
  preserve boolean dtype in encoding (pydata#7720)
  [skip-ci] Add alignment benchmarks (pydata#7738)
  ...
@kmuehlbauer kmuehlbauer deleted the fix-bool-int branch May 25, 2023 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reading and writing a zarr dataset multiple times casts bools to int8
3 participants