fix flake8 config

[mathause]

flake8 v6 now errors on inline comments in the config file. I don't like it but oh well...

[keewis]

some context on the change

yeah, that's a shame, especially since adding support for inline comments would be as easy as passing inline_comment_prefixes=("#",) to the RawConfigParser constructor. I suppose the fear was that with that the # character would be impossible to use in settings, which would make this a limitation of the configuration format. I think switching to a different format (yaml, toml) would have been possible, but I guess that's another can of worms.

I can understand that they're doing something, though, because silently ignoring based on letters from what is supposed to be comments is pretty bad.

To improve on this, we might be able to move the comments to a continuous block and prefix them with the error code, then use a collapsed (comma-separated) list of codes for the actual ignores. Something like this, maybe?

ignore =
    # E203: whitespace before ':' - doesn't work well with black
    # E402: module level import not at top of file
    # E501: line too long - let black worry about that
    # E731: do not assign a lambda expression, use a def
    # W50: line break before binary operator
    E203,E402,E501,E731,W50

The disadvantage would be that adding a new ignore changes two lines, and should we have lots of ignores the line wrapping would be a bit weird.

[mathause]

Thanks for the context @keewis - I like your suggestion & updated the PR. AFAIK we have not changed the ignored values in a very long time. I'll merge once the tests ran through.