-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix dtype complex for rasterio backend #5501
Conversation
Hello @Grouny! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2021-08-25 14:30:57 UTC |
@Grouny - thanks for this PR! And I see that this is your first time contributing to Xarray -- Welcome! This fix you propose looks great. Apart from the linter complaining about some whitespace, I think this would benefit from a simple test. Would you mind adding a test to Q for @snowman2 - is rioxarray handling complex datatypes in this way? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jhamman, there's a PR here: corteva/rioxarray#353
Co-authored-by: keewis <[email protected]>
Yes I can think about a test. Could this test be a simple .tiff file opening or is it too high level? |
Also see: corteva/rioxarray#359 |
As discussed in the dev meeting, this would be great to merge. The test could be to create a small file, and then read it. Would that work @Grouny ? |
I added a test in |
Unit Test Results 6 files 6 suites 51m 22s ⏱️ Results for commit 674d9b6. |
can you try if your test (without the other changes) fails with |
We're about to remove the built-in rasterio backend in favour of rioxarray. Sorry for not merging this earlier @agrouaze |
rasterio backend support for the
complex_int16
dtypewhats-new.rst