Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clearer terminology for coordinate variables #1296

Merged
merged 2 commits into from
Mar 15, 2017
Merged

Clearer terminology for coordinate variables #1296

merged 2 commits into from
Mar 15, 2017

Conversation

fmaussion
Copy link
Member

@fmaussion fmaussion commented Mar 5, 2017 •
edited
Loading

@fmaussion
Copy link
Member Author

cc @rabernat @shoyer

@rabernat
Copy link
Contributor

rabernat commented Mar 6, 2017

After additional discussion in #1295, I guess this should be revised.

@fmaussion
Copy link
Member Author

Yes. Let me know if you have a preference for the second coordinate type in #1295

@fmaussion
Copy link
Member Author

OK, this is ready for review.

@jhamman
Copy link
Member

jhamman commented Mar 15, 2017

Looks good to me.

shoyer
shoyer approved these changes Mar 15, 2017
View reviewed changes
Copy link
Member

@shoyer shoyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@fmaussion fmaussion merged commit 57776ab into pydata:master Mar 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shoyer shoyer shoyer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fmaussion @rabernat @jhamman @shoyer