np.cumproduct deprecated

[quantsnus]

What is your issue?

Since numpy version 1.25.0 np.cumproduct is deprecated in favor of np.cumprod.

The coordinates to_index() method still uses it

xarray/xarray/core/coordinates.py

Line 144 in 971be10

cumprod_lengths = np.cumproduct(index_lengths)

which results in an unecessary DeprecationWarning.

[dcherian]

Thanks @quantsnus This should be a really easy Pull Request. Do you have time to fix it?

We have contributing instructions here: https://docs.xarray.dev/en/stable/contributing.html

[TomNicholas]

In particular see the section of the contributing guide explaining how to add a deprecation warning

[keewis]

no need for a deprecation cycle since the cumproduct call is internal

[quantsnus]

Thanks @quantsnus This should be a really easy Pull Request. Do you have time to fix it?

I'll give it try. Will be my first contribution, but for a one-line change I guess it won't be too difficult.