Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

type checking CI is failing #7270

Closed
keewis opened this issue Nov 8, 2022 · 3 comments · Fixed by #7752
Closed

type checking CI is failing #7270

keewis opened this issue Nov 8, 2022 · 3 comments · Fixed by #7752

Comments

@keewis
Copy link
Collaborator

keewis commented Nov 8, 2022 •
edited
Loading

The most recent runs of the type checking CI have started to fail with a segfault:

/home/runner/work/_temp/dac0c060-b19a-435a-8063-bbc5b8ffbf24.sh: line 1:  2945 Segmentation fault      (core dumped) python -m mypy --install-types --non-interactive --cobertura-xml-report mypy_report

This seems to be due to the release of mypy=0.990.

#7269 pinned mypy to mypy<0.990, which should be undone once we figured out how to fix that (most likely by waiting on the next release), and any complaints the new version has (see this workflow run).
@keewis keewis added needs triage Issue that has not been reviewed by xarray team member and removed needs triage Issue that has not been reviewed by xarray team member labels Nov 8, 2022
@github-actions github-actions bot added the needs triage Issue that has not been reviewed by xarray team member label Nov 8, 2022
@keewis keewis removed the needs triage Issue that has not been reviewed by xarray team member label Nov 8, 2022
@headtr1ck
Copy link
Collaborator

Locally (Windows) it works for me.

Only lots of new errors, most importantly the change of mypy to no_implicit_optional=True.
Guess we can just fix this in a PR, I like the explicit defaults anyway better.

@headtr1ck headtr1ck mentioned this issue Nov 12, 2022
Merged
1 task
@keewis
Copy link
Collaborator Author

keewis commented Jan 23, 2023

should this have been closed by #7283?

@headtr1ck
Copy link
Collaborator

should this have been closed by #7283?

Too long ago...
I assume I had a reason why I didn't close this issue?

@headtr1ck headtr1ck mentioned this issue Apr 8, 2023
Merged
@Illviljan Illviljan mentioned this issue Apr 15, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix typing errors using mypy 1.2 Illviljan/xarray
2 participants
@keewis @headtr1ck