Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing parameter in DataArray.str.get #4334

Closed
keewis opened this issue Aug 11, 2020 · 1 comment · Fixed by #4339
Closed

missing parameter in DataArray.str.get #4334

keewis opened this issue Aug 11, 2020 · 1 comment · Fixed by #4339

Comments

@keewis
Copy link
Collaborator

keewis commented Aug 11, 2020

While working on #4286 I noticed that the docstring of DataArray.str.get claims to allow passing a default value in addition to the index, but the python code doesn't have that parameter at all.
I think the default value is a good idea and that we should make the code match the docstring.

@mathause
Copy link
Collaborator

Similarly str.wrap does not pass on its kwargs

def wrap(self, width, **kwargs):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants