Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.16.0 release #4031

Closed
16 of 23 tasks
dcherian opened this issue May 5, 2020 · 9 comments
Closed
16 of 23 tasks

0.16.0 release #4031

dcherian opened this issue May 5, 2020 · 9 comments

Comments

@dcherian
Copy link
Contributor

dcherian commented May 5, 2020

It'd be nice to issue a release soon. We should decide if this is a minor 0.15.2 or major 0.16.0

Please edit this list as you wish.

Must-have

Nice to have

@mathause
Copy link
Collaborator

mathause commented May 18, 2020

@max-sixty
Copy link
Collaborator

As discussed on the dev call, I'll take this one.

I think we need to do 0.16.0 as we had some backward-incompat changes (I can't remember now what they were; but can hunt them down if anyone otherwise has a preference for 0.15.2?)

@max-sixty max-sixty changed the title next release 0.16.0 release Jun 25, 2020
@dcherian
Copy link
Contributor Author

Yes we have some breaking changes so definitely 0.16.0

IMO we should do #4184 #4175 and #4163 and then release. #3985 is still waiting for a minimal example so perhaps we should leave that for the next release.

@max-sixty
Copy link
Collaborator

Agree! I'll keep an eye on those this week.

@max-sixty
Copy link
Collaborator

Thanks for updating @dcherian . Is it worth waiting for #3985? I'm still not sure exactly what the bug is there. I'd vote to leave it until we have a repro.

I was thinking of sneaking in #3891 but didn't want to bring it up as probably won't be able to; definitely not worth waiting on me for!

@dcherian
Copy link
Contributor Author

dcherian commented Jul 2, 2020

I'd vote to leave it until we have a repro.

👍 I'm also not sure what the bug is. In fact it's possible that a bug was fixed and a workaround is what's raising the error now :P

Re: #3891 do you mean set keep_attrs=True by default?

@max-sixty
Copy link
Collaborator

Re: #3891 do you mean set keep_attrs=True by default?

Exactly, so this will push to 0.17

@max-sixty
Copy link
Collaborator

FYI I will do this towards the end of this week or at the latest this weekend

@dcherian
Copy link
Contributor Author

Thanks @max-sixty !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants