You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In the pint integration tests I tried to also test calling numpy functions on xarray objects (we provide methods for all of them).
Some of these functions, like numpy.median, numpy.searchsorted and numpy.clip, depend on __array_function__ (i.e. not __array_ufunc__) to dispatch. However, neither Dataset nor DataArray (nor Variable, I think?) define these protocols (see #3643).
Should we define __array_function__ on xarray objects?
The text was updated successfully, but these errors were encountered:
I think this is probably a good idea, assuming we figure out the type casting hierarchy challenge. Right now people often check for the existence of __array_function__ to indicate NumPy duck arrays, which clearly isn't quite right.
In the
pint
integration tests I tried to also test calling numpy functions on xarray objects (we provide methods for all of them).Some of these functions, like
numpy.median
,numpy.searchsorted
andnumpy.clip
, depend on__array_function__
(i.e. not__array_ufunc__
) to dispatch. However, neitherDataset
norDataArray
(norVariable
, I think?) define these protocols (see #3643).Should we define
__array_function__
on xarray objects?The text was updated successfully, but these errors were encountered: