-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Terminology for the various coordinates #1295
Comments
Yes, let's call them "dimension coordinates". The later could be called "non-dimension coordinates", but even dimension coordinates are optional so we shouldn't call these "optional". |
Wherever possible we should try to adhere to CF convention terminology. Some relevant definitions are:
Using these definitions, it seems that @shoyer's "dimension coordinate" == CF's "coordinate variable" and @shoyer's "non-dimension coordinate" == CF's "auxiliary coordinate variable" |
Thanks @rabernat , I think this makes sense. I like "dimension coordinate" better and less ambiguous than "coordinate variable", but staying in line with CF clearly is the best thing to do here. |
I think it's confusing to use "coordinate" to refer to only variables matching dimension names and that "auxiliary coordinates" are not a type of coordinate. It just doesn't make any sense in terms of the usual rules for categorizing things. This is especially problematic for software like xarray which people use without looking carefully at the docs, and for which many users aren't familiar with CF conventions. So I feel pretty strongly that CF/NUG conventions get this one wrong, and for xarray we should say that anything in |
I don't feel very strongly about this...just pointing out that CF conventions do define terminology relevant to this discussion. I'm fine with departing from CF convention terminology where we think it is unnecessarily confusing. But we should try to explain how and why we depart in the docs. @shoyer's comment above would in fact be a useful addition to the docs. |
I'm fine with this too. In particular, I find "dimension coordinate" much more meaningful than just "coordinate variable". Do I read this correctly that we agree on:
I'm also fine with "auxiliary coordinates" for the second type. Let me know which one we should pick, I'll update the PR accordingly. |
I personally like "auxiliary coordinate" for the second type. This makes it clear that the variable gives additional information that is not as fundamental as the "dimension coordinate". |
I agree that "auxiliary coordinate" is a better name, but I think "non-dimension coordinate" is clearer for the rare cases where we want to refer to these coordinates, given that we don't have any name for these coordinates in the xarray data model itself. |
Picking up a thread about the
repr
(#1199 (comment)), I think it would be good to give a name to the two different types of coordinates in xarray.Currently the doc says:
The use of quotation marks in
“dimension” coordinates
makes the term imprecise. Should we simply call the formerdimension coordinates
and the latteroptional coordinates
?This would also help to uniformize error reporting (e.g. #1291 (comment))
The text was updated successfully, but these errors were encountered: