From e545137dc9860734a864f07fad5e6e72f8f58a74 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Kai=20M=C3=BChlbauer?= Date: Fri, 17 Nov 2023 10:41:05 +0100 Subject: [PATCH] add suggestions from review --- doc/whats-new.rst | 3 ++- xarray/coding/variables.py | 2 +- xarray/conventions.py | 2 +- 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/doc/whats-new.rst b/doc/whats-new.rst index 6bae0fac99e..7ff71d2a2d3 100644 --- a/doc/whats-new.rst +++ b/doc/whats-new.rst @@ -40,8 +40,9 @@ Breaking changes - drop support for `cdms2 `_. Please use `xcdat `_ instead (:pull:`8441`). By `Justus Magin =0.22``. By `Deepak Cherian `_. +- Minimum supported versions for the following packages have changed: ``h5py >=3.7``, ``h5netcdf>=1.1``. + By `Kai Mühlbauer `_. Deprecations ~~~~~~~~~~~~ diff --git a/xarray/coding/variables.py b/xarray/coding/variables.py index 085725b4b7c..487197605e8 100644 --- a/xarray/coding/variables.py +++ b/xarray/coding/variables.py @@ -564,7 +564,7 @@ def decode(self): raise NotImplementedError() -class ObjectStringCoder(VariableCoder): +class ObjectVLenStringCoder(VariableCoder): def encode(self): return NotImplementedError diff --git a/xarray/conventions.py b/xarray/conventions.py index 65c55207e2a..75f816e6cb4 100644 --- a/xarray/conventions.py +++ b/xarray/conventions.py @@ -266,7 +266,7 @@ def decode_cf_variable( var = strings.EncodedStringCoder().decode(var) if original_dtype == object: - var = variables.ObjectStringCoder().decode(var) + var = variables.ObjectVLenStringCoder().decode(var) original_dtype = var.dtype if mask_and_scale: