Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Soften edges / shading around admonitions #470

Closed
choldgraf opened this issue Sep 20, 2021 · 1 comment · Fixed by #472
Closed

Soften edges / shading around admonitions #470

choldgraf opened this issue Sep 20, 2021 · 1 comment · Fixed by #472

Comments

@choldgraf
Copy link
Collaborator

Description

In the book theme we recently softened the admonitions a bit, since a lot of web design best-practices recommend rounded corners rather than hard edges, and we tweaked the shadowing as well.

Would others be interested in upstreaming these improvements to this theme? It would look something like this:

OLD:

image

NEW:

image

Implementation details

Here's the PR where this was added in the book theme, it wasn't too much CSS! https://github.com/executablebooks/sphinx-book-theme/pull/352/files

@jorisvandenbossche
Copy link
Member

Sounds good to me! I would maybe use a slightly smaller border-radius (you used 0.4em in sphinx-book-theme, eg furo uses 0.2rem)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants