-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
genindex.html, Hlists (and possibly more table-based items) become funky after 0.15.3 upgrade #1855
Comments
Thanks for raising this @abjarna. Adding a screenshot of the dark version: I do not think the grey background is an issue since this is a table (albeit a special case of a table), but perhaps the hover colour (purple) could be removed as the focus item for interaction will be the links inside a given cell. Thoughts @gabalafou @smeragoel |
Ok, thank you! I wasn't aware of #1757, but in my opinion this makes the genindex.html look really bad. In addition, the genindex.html now looks totally different from previous versions, which was probably not the intention of #1757. Also, the grey background either overlaps between left and right column, or creates a thin table border. This results in a thin line in front of the right column in the genindex.html. See attachment. I haven't yet tried to fix this in my custom.css, but it's probably an easy fix. However, I recommend a more permanent fix to prevent the above changes to genindex.html. |
I also found similar issues when using Hlists. This page uses version 0.15.3: This page uses version 0.15.2: Are you @trallard aware of any ways to disable these grey colors and purple color when hovering, besides using custom CSS? |
Aha! Another item we did not realise was a table. Edit the correct PR that introduced this is #1757
Unfortunately, right now, you'd need to add custom styles specifically to override these lines pydata-sphinx-theme/src/pydata_sphinx_theme/assets/styles/abstracts/_mixins.scss Lines 44 to 55 in 97e60ba
tough this would affect all tables on your site. |
Thank you for the quick response @trallard ! And also thanks for all your hard work on the PyData theme. Best Sphinx theme out there by far! 🙏 |
Thank you for reporting these style mishaps 🙏🏽 I am tagging @gabalafou and @smeragoel here as they were the main folks working on tables restyling: folks let's chat about this and scope any further improvements needed |
Quick fix: #1864. Ideally, we would change the output for both hlists and the index page to not use tables. These are using tables only for layout, not semantically to actually communicate tabular data. |
Are you suggesting we do that in the theme? Or as an upstream change to sphinx? |
Upstream, if we can |
So that would more than likely be at the Sphinx level |
Hi again, I see this has been fixed in the latest version (v0.15.4dev0). Both the latest version (v0.15.4dev0) and version 0.15.3, show table-hover behaviour in "kitchen-sink/tables.html": And only version 0.15.3 show table-hover behaviour in "genindex.html", but NOT the latest version (v0.15.4dev0): And finally, only version 0.15.3 show table-hover behaviour in "kitchen-sink/lists.html", but NOT the latest version (v0.15.4dev0): I've been trying to replicate the quick fix #1864 from @gabalafou in my local environment, by removing the line "@include table-colors;" from _tables.scss in my virtual environment folder, and then rebuilding with "make clean && make html", but still no luck 😢 Am I missing something obvious, or are there additional steps I need to make to replicate the behaviour in latest version (v0.15.4dev0)? |
And a quick note to other users who might also be struggling with the same issue, this addition to custom.css temporarily undoes the table-hover behaviour in "genindex.html":
|
the If you're testing on the theme's own website, you could do |
Thank you @drammock! In that case, I’ll stick to the custom.css in my previous comment for now. |
This page uses version 0.15.3:
https://pydata-sphinx-theme.readthedocs.io/en/v0.15.3/genindex.html
This page uses version 0.15.2:
https://pydata-sphinx-theme.readthedocs.io/en/v0.15.2/genindex.html
The style in genindex.html is as expected in version 0.15.2, but in version 0.15.3 the indextable has dark grey color and purple color when hovering.
See attached screenshots:
The text was updated successfully, but these errors were encountered: