-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Layout changed with Sphinx 7.2.6 #1452
Comments
the first image of your comment is using pydata-sphinx-theme 0.13.x and the secode one 0.14.0. I think it's completely unrelated to Sphinx version. Could you check again and let us know ? |
Indeed, you're right. The first and second images are using, respectively:
Such radical changes in the layout between |
Only 2 changes a modifying what you see:
In general, I would suggest to reduce your title names by using aliases in you toctree. It will be easier to read and avoid this kind of behaviors. I updated all my sites this WE and transitions were very smooth. Always remember that your navbar will be displayed to user with smaller screen than yours so in your case anything smaller than a laptop was already an issue. |
Isn't the background color of the announcement banner changed as well?
Thanks but I don't see any
Indeed. Too bad: it used to work nicely with 0.13.3.
Do you mean the large horizontal space between the logo and the titles?
Thanks!
Some of them are not that long, but anyway on 2 lines, e.g. „Cette FAQ“. AFAICS, the problem comes from the large horizontal space between the logo and the titles. |
Of course that was the main purpose of the new version. New maintainers have given have done a tremendous work on accessibility, the new color scheme is part of it. The warning banner can be deactivated if needed, it was a request from big projects like bokeh, numpy, pandas etc...
it's related to #1410 but in short you could use:
It should work |
Ah, sorry, I wasn't aware: many thanks for the hard work!
But I (currently) needed it! 😉 And it was possible to deactivate it, just by not making use of: html_theme_options = {
...,
"announcement": "...",
...,
} isn't it?
Indeed, thanks. The site is still suffering from the 2-lines titles. But I guess, it will be fixed when the large horizontal space between the logo and the titles will be removed. |
About the large horizontal space between the logo and the titles, the difference between the two versions seems to be:
<div class="navbar-header-items__start">
<div class="navbar-item">
<a class="navbar-brand logo" href="../index.html">
<img ...>
<div class="col-lg-3 navbar-header-items__start">
<div class="navbar-item">
<a class="navbar-brand logo" href="../index.html">
<img ...>
... (note the extra |
ok now I remember, we placed the navbar-nav in the middle so it remains alined with articles at all times. Your configuration is unusual in our community. The more classic config is very small titles that open vast list in the primary sidebar. The problem then is that if no version switcher was set, the nav list was ending completely off to the left on big screens. This solved it for example here: So I think we won't change it back from our side. That being said, nothing is preventing you to add a small css patch for you documentation. If you share the latest build url I can search with you the correct set of css parameters to tune. |
But mine are not much longer than the ones on PyData Sphinx Theme site, e.g. „Domaines spécialisés“ vs „Contributor Guide“.
Isn't it the case on our site as well?
Solution: version switcher, not at the right, but at the left of the nav list 😉.
Thanks! I'll let you know when I could provide it. |
One page of our latest build is e.g. this one. Thanks again for your help! |
Even if I remove the Your section titles are simply too long to fit all on one line. I suggest using the "More" menu: https://pydata-sphinx-theme.readthedocs.io/en/stable/user_guide/header-links.html#navigation-bar-dropdown-links |
could you try to remove the class as suggested by @drammock and use the "search-button" widget instead of the default "search-button-field" ? |
Indeed , that's what I observed as well.
But all these titles are equally “interesting” so I'd like to keep all of them immediately visible, just as it was the case with v. 0.13.3. |
have you tried what I suggested ? |
If you mean removing it with the Web development tools of e.g. Firefox, yes. And, combined with which is much much better, thanks to both of you. Now:
|
please open a new issue for misalignement of the search button (as it's not the preferred icon anymore). |
OK, I'll do it.
It doesn't work. |
Ah, it does work with Thanks! |
sorry we still have this one pending if you wanna help: #1391 |
I'll try to have a look but I guess I'm much less expert in |
Found it, #1174. |
The
PyData Sphinx Theme
0.14.0:Sphinx
7.1.2, used to give the expected layout:Sphinx
7.2.6, gives the following unexpected layout:It would be nice to have the same layout with
Sphinx
7.2.6 as withSphinx
7.1.2.The text was updated successfully, but these errors were encountered: