Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excess padding in nav bar dropdown #1421

Open
gabalafou opened this issue Aug 24, 2023 · 4 comments
Open

Excess padding in nav bar dropdown #1421

gabalafou opened this issue Aug 24, 2023 · 4 comments
Assignees
Labels
tag: CSS CSS and SCSS related issues

Comments

@gabalafou
Copy link
Collaborator

gabalafou commented Aug 24, 2023

      .dropdown-menu {
        z-index: $zindex-popover;
        border: 1px solid var(--pst-color-border);
        box-shadow: 0 0 0.3rem 0.1rem var(--pst-color-shadow);
        background-color: var(--pst-color-on-background);
        padding: 0.5rem 0;

IMO we don't need the top/bottom padding either, but feel free to ignore this suggestion if you disagree

        padding: 0;

Originally posted by @drammock in #1414 (comment)

@trallard trallard added the tag: CSS CSS and SCSS related issues label Jun 4, 2024
@gabalafou
Copy link
Collaborator Author

If I understand correctly, this is what the before / after screenshots would look like (ignore the purple focus ring) after applying the change suggested here:

Before After
before padding after 0 padding

@gabalafou
Copy link
Collaborator Author

gabalafou commented Jun 4, 2024

I think I prefer the before screenshot because the padding looks more equal. In fact, I might even increase the vertical padding some.

@drammock
Copy link
Collaborator

drammock commented Jun 4, 2024

no strong feeling now that I've seen them side by side. Feel free to close if you like.

@trallard
Copy link
Collaborator

trallard commented Jun 4, 2024

+1 on keeping the padding after seeing the comparison - think it would also be useful for anyone using touch devices

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tag: CSS CSS and SCSS related issues
Projects
None yet
Development

No branches or pull requests

3 participants