Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several issues with version switcher #1345

Closed
drammock opened this issue Jun 8, 2023 · 3 comments
Closed

Several issues with version switcher #1345

drammock opened this issue Jun 8, 2023 · 3 comments
Labels
impact: block-release Should block a release from happening. Only use if this is a critical problem we don't want to ship kind: bug Something isn't working

Comments

@drammock
Copy link
Collaborator

drammock commented Jun 8, 2023

Currently the version switcher on main is broken, and there are several open (or recently closed) issues/PRs about it. This issue is an attempt to get everyone on the same page:

IMO next step should be to move forward with #1305 as the starting point, but set aside the remaining issues with aria roles (and open a new issue to track that unfinished work). I'll try to get to that later today, but if others have time feel free to take a look and review / propose changes to what is currently there.

cc @12rambau @lagru @alphapapa @jpfeuffer

@12rambau
Copy link
Collaborator

12rambau commented Jun 8, 2023

I tried to work on #1343 but I don't manage to reproduce the bug locally. Even when I set up a server, the redirection is working as expected. So instead I'm focusing on #1344 first (so that PR build can be used as real life test material).

@drammock
Copy link
Collaborator Author

drammock commented Jun 8, 2023

when I recently helped NumPy update to theme version 0.13.3 the version dropdown was working in PR builds and also on local builds (numpy/numpy#23647 (comment)) but I guess that's because their json_url is a real URL (not a relative path)?

@trallard trallard added the kind: bug Something isn't working label Jun 16, 2023
@12rambau 12rambau added the impact: block-release Should block a release from happening. Only use if this is a critical problem we don't want to ship label Jun 20, 2023
@drammock
Copy link
Collaborator Author

closing in favor of #1357 and #1358. I'll add the block-release tag to #1357 instead of this one.

@drammock drammock closed this as not planned Won't fix, can't repro, duplicate, stale Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact: block-release Should block a release from happening. Only use if this is a critical problem we don't want to ship kind: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants