Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate tests related to specific settings sources #427

Closed
makukha opened this issue Sep 27, 2024 · 1 comment · Fixed by #429
Closed

Separate tests related to specific settings sources #427

makukha opened this issue Sep 27, 2024 · 1 comment · Fixed by #429

Comments

@makukha
Copy link
Contributor

makukha commented Sep 27, 2024

Pydantic Settings has excellent test coverage, but tests are collected in only 3 files, leading to e.g. ~5200 lines in test_settings.py. IMO, testing code could be more maintainable if every source has a separate file, if possible.

I could provide PR if this improvement sounds reasonable.

@hramezani
Copy link
Member

Thanks @makukha for this issue.

It would be great if you can help here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants