Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cargo include #852

Merged
merged 1 commit into from
Aug 8, 2023
Merged

Conversation

vvanglro
Copy link
Contributor

@vvanglro vvanglro commented Aug 4, 2023

When referring to pydantic-core, I found that the include path in the cargo.toml file is wrong.

I run cargo package --list and it's not included. So it should include the python folder?

Selected Reviewer: @samuelcolvin

Signed-off-by: vvanglro <[email protected]>
@vvanglro
Copy link
Contributor Author

vvanglro commented Aug 4, 2023

please review

@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Merging #852 (d7dc8cb) into main (ca1055b) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #852   +/-   ##
=======================================
  Coverage   93.52%   93.52%           
=======================================
  Files         102      102           
  Lines       14609    14609           
  Branches       25       25           
=======================================
  Hits        13663    13663           
  Misses        940      940           
  Partials        6        6           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca1055b...d7dc8cb. Read the comment docs.

@codspeed-hq
Copy link

codspeed-hq bot commented Aug 4, 2023

CodSpeed Performance Report

Merging #852 will degrade performances by 46.09%

Comparing vvanglro:fix/cargo_include (d7dc8cb) with main (ca1055b)

Summary

🔥 7 improvements
❌ 8 regressions
✅ 120 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main vvanglro:fix/cargo_include Change
test_core_python_fs 235.3 µs 264.9 µs -11.18%
test_core_string_lax_wrong 40 µs 59.6 µs -32.91%
🔥 test_core_python 46 µs 41.1 µs +11.81%
test_core_future_str 26.8 µs 30.1 µs -10.95%
🔥 test_core_future 53.5 µs 42.7 µs +25.32%
🔥 test_date_from_str 25.8 µs 22.9 µs +12.71%
🔥 test_date_from_datetime 38.8 µs 35.2 µs +10.51%
🔥 test_core_future_str 25.4 µs 22.9 µs +10.99%
test_core_python 41.6 µs 46.7 µs -10.8%
test_dont_raise_error 25.5 µs 38 µs -32.99%
test_dont_raise_error_no_info 22.9 µs 27.6 µs -17.14%
🔥 test_validate_literal[python-few_mixed] 25.3 µs 22.5 µs +12.3%
test_tagged_union_int_keys_python 30.3 µs 56.3 µs -46.09%
test_core_model_py 47.9 µs 61.2 µs -21.74%
🔥 test_core_model_py_extra 67.9 µs 56.8 µs +19.7%

@samuelcolvin samuelcolvin merged commit 1bd36f1 into pydantic:main Aug 8, 2023
29 of 30 checks passed
@samuelcolvin
Copy link
Member

thanks so much.

@vvanglro vvanglro deleted the fix/cargo_include branch September 12, 2023 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants