Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Social media account not being linked correctly #44

Open
mattcen opened this issue Sep 11, 2024 · 2 comments
Open

🐛 Social media account not being linked correctly #44

mattcen opened this issue Sep 11, 2024 · 2 comments

Comments

@mattcen
Copy link
Collaborator

mattcen commented Sep 11, 2024

Describe the bug

Social media fields from Pretalx aren't being templated correctly into HTML

The fields in Pretix for both Fedi and Bsky say:

Use @username@domain format (for example, @[email protected]). If you choose to fill this in, it will be published in the schedule. This content will be shown publicly.

I assume the Bsky one was copied from the Fedi one; they have completely different address formats.

URL to reproduce the bug

https://2024.pycon.org.au/pycon-au-2024/speaker/PFTMME/

What is your Mastodon/Fediverse handle? –

@[email protected]

The fedi handle gets converted to a mailto link

What is your Twitter/X handle? –

@minxdragon

Twitter/X isn't linked at all.

What is your Bluesky handle? –

@[email protected]

Bsky gets converted to a mailto also, and should actually say minxdragon.bsky.social, (or https://bsky.app/profile/minxdragon.bsky.social which is better, because I, for example, have a bsky handle of mattcen.com, but an address of https://bsky.app/profile/mattcen.com).

Sorry, I couldn't easily work out where to fix this rendering or this would have been a PR. I also can't see where this bsky info is coming from, because the YAML doesn't seem to have it, nor pronouns: https://github.com/pyconau/2024-website/blob/main/src/content/people/PFTMME.yml, so I suspect this isn't being used any more, and is being pulled from Pretix in some other way?

@urcheraus
Copy link
Collaborator

Thanks for reporting the issue @mattcen, we'll look into it

@daisylb
Copy link
Member

daisylb commented Sep 12, 2024

Hey Matt! This issue (and the weird auto linking) is because of a workaround we used to publish the schedule quickly, which has now been reverted and replaced with the usual layout we've used since 2020 in #45.

There's still a tiny bit of extra work needed to copy across social media handles (right now they are not shown at all) so I'll leave this open for now, but a fix is in progress :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants