Recommend isal on PyPy and aarch64 platforms #122
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did some benchmarks on my olimex olinuxino A64 with allwinner A64 chip. (AArch64 architecture). This was to ascertain the performance of python-zlib-ng. I also took python-isal into the comparison.
It appears that isal and zlib-ng do not speed up decompression, but both do speed up compression. In fact, isal is three times faster at the levels it supports.
I removed aarch64 support once: #79. But that was before I made python-isal into a C-module. Apparently the Cython module had some performance issues on aarch64. Luckily isal and zlib-ng python modules are both implemented in C now.
This is a quick and easy PR. I guess I should add zlib-ng now.
As for PyPy, I do run the full test suite and it works. Generally PyPy is very slow in calling C-extensions, but that is an overhead that applies equally to all deflate libraries.