Skip to content

Commit

Permalink
fix: disable unused username/password config
Browse files Browse the repository at this point in the history
  • Loading branch information
jakobrosenberg committed Apr 1, 2022
1 parent 0dafb21 commit 518c8f0
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions src/commands/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -228,8 +228,9 @@ class Commands {
const result = await vscode.window.showQuickPick(
[
{ label: "autoConnect", description: config.autoConnect },
{ label: "username", description: config.username || "" },
{ label: "password", description: config.password || "" },
// todo are we adding telnet?
// { label: "username", description: config.username || "" },
// { label: "password", description: config.password || "" },

This comment has been minimized.

Copy link
@Josverl

Josverl Apr 5, 2022

Contributor

@jakobrosenberg : if/when you plan to support webrepl connections through micropython-ctl then the password could still be useful, but afaik there has been little development in the last 2 years , and there appear to be issues with the transfer of binary files

This comment has been minimized.

Copy link
@jakobrosenberg

jakobrosenberg Apr 5, 2022

Author Contributor

AFAIK Pycom devices don't support webrepl at all, so the solution will be to add telnet support to micropython-ctl.

],
{}
);
Expand Down

0 comments on commit 518c8f0

Please sign in to comment.