-
Notifications
You must be signed in to change notification settings - Fork 25
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: disable unused username/password config
- Loading branch information
1 parent
0dafb21
commit 518c8f0
Showing
1 changed file
with
3 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -228,8 +228,9 @@ class Commands { | |
const result = await vscode.window.showQuickPick( | ||
[ | ||
{ label: "autoConnect", description: config.autoConnect }, | ||
{ label: "username", description: config.username || "" }, | ||
{ label: "password", description: config.password || "" }, | ||
// todo are we adding telnet? | ||
// { label: "username", description: config.username || "" }, | ||
// { label: "password", description: config.password || "" }, | ||
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
jakobrosenberg
Author
Contributor
|
||
], | ||
{} | ||
); | ||
|
@jakobrosenberg : if/when you plan to support webrepl connections through micropython-ctl then the password could still be useful, but afaik there has been little development in the last 2 years , and there appear to be issues with the transfer of binary files