Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

semantic-release-pypi@^3.0.0 uses the pyproject.toml based build system interface, if a pyproject.toml file exists #26

Closed
abichinger opened this issue Oct 26, 2023 · 3 comments · Fixed by #27
Assignees
Labels
enhancement New feature or request

Comments

@abichinger
Copy link
Contributor

This project uses setup.py to build and pyproject.toml only for linting.

This will cause the release workflow to fail with the following error:

Traceback (most recent call last):
  File "/opt/hostedtoolcache/node/18.18.2/x64/lib/node_modules/semantic-release-pypi/dist/py/set_version.py", line 24, in <module>
    toml['project']['version'] = args.version
  File "/opt/hostedtoolcache/Python/3.8.18/x64/lib/python3.8/site-packages/tomlkit/container.py", line 613, in __getitem__
    raise NonExistentKey(key)
tomlkit.exceptions.NonExistentKey: 'Key "project" does not exist.'

The PyPA recommends to migrate away from setup.py (Build System Interface)

Related:

Projects that are also affected:

@casbin-bot
Copy link

@techoner @Nekotoxin

@casbin-bot casbin-bot added the enhancement New feature or request label Oct 26, 2023
@abichinger abichinger changed the title semantic-release-pypi@^3.0.0 uses the pyproject.toml based build system interface, if a pyproject.toml file exists. semantic-release-pypi@^3.0.0 uses the pyproject.toml based build system interface, if a pyproject.toml file exists Oct 26, 2023
@hsluoyz
Copy link
Member

hsluoyz commented Oct 26, 2023

@abichinger hi, can you make a PR?

@abichinger
Copy link
Contributor Author

Hi, I'm going to make a PR in the next few days

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants