Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid rebuild if OCV unaffected by parameters #449

Open
NicolaCourtier opened this issue Aug 7, 2024 · 0 comments
Open

Avoid rebuild if OCV unaffected by parameters #449

NicolaCourtier opened this issue Aug 7, 2024 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@NicolaCourtier
Copy link
Member

Feature description

Rebuild the model for a specified initial_state only if the OCV relationship is affected by the fitting parameters. Such parameters would include those that affect the stoichiometric limits and possibly degradation parameters.

Motivation

To speed up optimisations which don't require a model rebuild.

Possible implementation

Similar to the geometric_parameters?

Additional context

Should be tackled after #444.

@NicolaCourtier NicolaCourtier added the enhancement New feature or request label Aug 7, 2024
@BradyPlanden BradyPlanden added the good first issue Good for newcomers label Aug 13, 2024
@NicolaCourtier NicolaCourtier removed this from v24.12 Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants