Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor BaseModel property setters #445

Open
BradyPlanden opened this issue Aug 7, 2024 · 0 comments · Fixed by #448
Open

Refactor BaseModel property setters #445

BradyPlanden opened this issue Aug 7, 2024 · 0 comments · Fixed by #448
Labels
enhancement New feature or request

Comments

@BradyPlanden
Copy link
Member

Feature description

Refactor the property setters within BaseModel within the aim to ensure these are safe and robust to use.

PyBOP/pybop/models/base_model.py

Line 727 in ebb03e4

@spatial_methods.setter

Motivation

At the moment, these completed a copy of the passed object, but don't ensure the BaseModel class reconstructs the change.

Possible implementation

No response

Additional context

No response
@BradyPlanden BradyPlanden added the enhancement New feature or request label Aug 7, 2024
@BradyPlanden BradyPlanden mentioned this issue Aug 7, 2024
Merged
15 tasks
@BradyPlanden BradyPlanden added the release blocker Needs to be closed before a new release can be deployed label Aug 7, 2024
@NicolaCourtier NicolaCourtier mentioned this issue Aug 7, 2024
Merged
15 tasks
@github-project-automation github-project-automation bot moved this to Done in v24.9 Aug 7, 2024
@NicolaCourtier NicolaCourtier reopened this Aug 7, 2024
@NicolaCourtier NicolaCourtier removed the release blocker Needs to be closed before a new release can be deployed label Aug 7, 2024
@NicolaCourtier NicolaCourtier moved this from Done to Todo in v24.9 Aug 28, 2024
@NicolaCourtier NicolaCourtier removed this from v24.9 Aug 28, 2024
@NicolaCourtier NicolaCourtier moved this to Todo in v24.12 Aug 28, 2024
@NicolaCourtier NicolaCourtier removed this from v24.12 Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add model.clear and remove setters pybop-team/PyBOP
2 participants
@NicolaCourtier @BradyPlanden