Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design problems should have a default init_soc #421

Closed
NicolaCourtier opened this issue Jul 24, 2024 · 0 comments · Fixed by #422
Closed

Design problems should have a default init_soc #421

NicolaCourtier opened this issue Jul 24, 2024 · 0 comments · Fixed by #422
Assignees
Labels
bug Something isn't working

Comments

@NicolaCourtier
Copy link
Member

Python Version

3.10

Describe the bug

If an init_soc value is not passed to DesignProblem, then predictions may start from incompatible initial states. For example, the formation concentrations may be taken as (infeasible) initial concentrations, which returns the following error message. To resolve this issue, init_soc should either be a required input or take a default initial value for design optimisation problems.

Steps to reproduce the behaviour

Check by removing the init_soc parameter from the spme_max_energy example script.

Relevant log output

pybamm.expression_tree.exceptions.SolverError: Step 'Discharge at 1C until 2.5 V (5 seconds period)' is infeasible due to exceeded bounds at initial conditions.
@NicolaCourtier NicolaCourtier added the bug Something isn't working label Jul 24, 2024
@NicolaCourtier NicolaCourtier self-assigned this Jul 24, 2024
@NicolaCourtier NicolaCourtier linked a pull request Jul 24, 2024 that will close this issue
15 tasks
@NicolaCourtier NicolaCourtier moved this to Done in v24.9 Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant