Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Hessian check for 2-parameter problems #363

Open
wants to merge 23 commits into
base: develop
Choose a base branch
from

Conversation

NicolaCourtier
Copy link
Member

Description

Add a classify_using_Hessian function that can assess the identifiability of an optimisation result and return an informative message to the user.

Issue reference

Fixes #362.

Review

Before you mark your PR as ready for review, please ensure that you've considered the following:

  • Updated the CHANGELOG.md in reverse chronological order (newest at the top) with a concise description of the changes, including the PR number.
  • Noted any breaking changes, including details on how it might impact existing functionality.

Type of change

  • New Feature: A non-breaking change that adds new functionality.
  • Optimization: A code change that improves performance.
  • Examples: A change to existing or additional examples.
  • Bug Fix: A non-breaking change that addresses an issue.
  • Documentation: Updates to documentation or new documentation for new features.
  • Refactoring: Non-functional changes that improve the codebase.
  • Style: Non-functional changes related to code style (formatting, naming, etc).
  • Testing: Additional tests to improve coverage or confirm functionality.
  • Other: (Insert description of change)

Key checklist:

  • No style issues: $ pre-commit run (or $ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
  • All unit tests pass: $ nox -s tests
  • The documentation builds: $ nox -s doctest

You can run integration tests, unit tests, and doctests together at once, using $ nox -s quick.

Further checks:

  • Code is well-commented, especially in complex or unclear areas.
  • Added tests that prove my fix is effective or that my feature works.
  • Checked that coverage remains or improves, and added tests if necessary to maintain or increase coverage.

Thank you for contributing to our project! Your efforts help us to deliver great software.

@NicolaCourtier NicolaCourtier linked an issue Jun 14, 2024 that may be closed by this pull request
Copy link

codecov bot commented Jun 14, 2024

Codecov Report

Attention: Patch coverage is 98.11321% with 1 line in your changes missing coverage. Please review.

Project coverage is 99.15%. Comparing base (c8b00e6) to head (7f1fea2).
Report is 32 commits behind head on develop.

Files with missing lines Patch % Lines
pybop/_classification.py 98.11% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #363      +/-   ##
===========================================
+ Coverage    99.08%   99.15%   +0.07%     
===========================================
  Files           52       57       +5     
  Lines         3605     4041     +436     
===========================================
+ Hits          3572     4007     +435     
- Misses          33       34       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@NicolaCourtier NicolaCourtier marked this pull request as ready for review December 6, 2024 11:29
@NicolaCourtier
Copy link
Member Author

I think we should continue with the slightly low coverage (98%) - the Hessian check is missing a test on the case where the optimal point is a saddle point for which we would need a relevant optimisation problem (this relates to #391).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a simple post-optimisation identifiability check
1 participant