Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Error in RMSE gradient calculation #354

Closed
NicolaCourtier opened this issue Jun 10, 2024 · 0 comments · Fixed by #355
Closed

[Bug]: Error in RMSE gradient calculation #354

NicolaCourtier opened this issue Jun 10, 2024 · 0 comments · Fixed by #355
Assignees
@NicolaCourtier
Labels
bug Something isn't working

Comments

@NicolaCourtier
Copy link
Member

Python Version

3.10

Describe the bug

There is an error in our formulation of the gradient for the RootMeanSquaredError in evaluateS1.

Steps to reproduce the behaviour

It can be seen by studying the trajectory of a gradient-based optimiser, or by inspection of the formula.

Relevant log output

No response
@NicolaCourtier NicolaCourtier added the bug Something isn't working label Jun 10, 2024
@NicolaCourtier NicolaCourtier self-assigned this Jun 10, 2024
@NicolaCourtier NicolaCourtier mentioned this issue Jun 10, 2024
Merged
15 tasks
@NicolaCourtier NicolaCourtier linked a pull request Jun 10, 2024 that will close this issue
Fix RMSE gradient #355
Merged
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NicolaCourtier NicolaCourtier

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix RMSE gradient pybop-team/PyBOP
1 participant
@NicolaCourtier