Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add remaining PyBaMM Models #219

Closed
3 of 4 tasks
BradyPlanden opened this issue Feb 26, 2024 · 0 comments · Fixed by #250
Closed
3 of 4 tasks

Add remaining PyBaMM Models #219

BradyPlanden opened this issue Feb 26, 2024 · 0 comments · Fixed by #250
Assignees
@BradyPlanden
Labels
enhancement New feature or request

Comments

@BradyPlanden
Copy link
Member

BradyPlanden commented Feb 26, 2024 •
edited
Loading

Feature description

We've had a few requests to expand our supported models. This issue is to add the remaining of the commonly used models such as,

  • Doyle Fuller Newman
  • Multi Particle Model (MPM)
  • Multi Species Multi Reaction (MSMR)
  • Half Cell?

Motivation

No response

Possible implementation

No response

Additional context

No response
@BradyPlanden BradyPlanden added the enhancement New feature or request label Feb 26, 2024
@BradyPlanden BradyPlanden self-assigned this Mar 17, 2024
@BradyPlanden BradyPlanden mentioned this issue Mar 20, 2024
Merged
14 tasks
@BradyPlanden BradyPlanden linked a pull request Mar 20, 2024 that will close this issue
Adds DFN, MPM, MSMR models #250
Merged
14 tasks
@BradyPlanden BradyPlanden moved this to In Progress in v24.6 Mar 21, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in v24.6 Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BradyPlanden BradyPlanden

Labels
enhancement New feature or request
Projects
v24.6
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adds DFN, MPM, MSMR models pybop-team/PyBOP
1 participant
@BradyPlanden