Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump rules_python version in example #93

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

hofbi
Copy link
Contributor

@hofbi hofbi commented Jul 24, 2024

This is not required since the local version is used

@jiawen
Copy link
Collaborator

jiawen commented Aug 6, 2024

This is not required since the local version is used

I think we still want this? It's more in the Google style to explicitly declare your direct dependencies rather than rely on them transitively. Since I just merged #95, in this case, the MVS algorithm should pick the lower of the two versions of rules_python.

In light of that, do you want to bump this rules_python version too?

@hofbi hofbi force-pushed the remove-duplicate-dep branch from ae15e54 to 02e56da Compare August 6, 2024 20:59
@hofbi hofbi changed the title Remove duplicated dependency Bump rules_python version in example Aug 6, 2024
@hofbi
Copy link
Contributor Author

hofbi commented Aug 6, 2024

Done

@jiawen jiawen merged commit e25b5e6 into pybind:master Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants