Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Semi-circle for the SPMe #18

Closed
noelhallemans opened this issue Jul 12, 2024 · 1 comment
Closed

Semi-circle for the SPMe #18

noelhallemans opened this issue Jul 12, 2024 · 1 comment

Comments

@noelhallemans
Copy link
Contributor

Hi,

Comparing EIS data of different models in compare_models.py, it appears that the SPMe does not have a semi-circle for the same electrode double-layer capacity as the other models.

options={"surface form": "differential"} and both positive and negative electrode double-layer capacities are set to 0.2 F m-2 for the figure below

Screenshot 2024-07-12 at 14 31 47

This is unexpected as the semi-circles of all models should be quite similar!

Interestingly, semi-circles for the SPMe appear when choosing the electrode double-layer capacity values unreasonably high:

100 F/m2: image

compared to 0.2 F/m2: Screenshot 2024-07-12 at 14 38 43

This may be related to the bug in leading surface form conductivity (pybamm-team/PyBaMM#4139), however, using the develop branch does not solve this issue.

We use PyBAMM version 24.1.

Kind regards,

Noël

@rtimms
Copy link
Collaborator

rtimms commented Jul 25, 2024

will be fixed by pybamm-team/PyBaMM#4293

@rtimms rtimms closed this as completed Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants