Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v24.11.0 #4598

Merged
merged 175 commits into from
Nov 21, 2024
Merged
Changes from 1 commit
Commits
Show all changes
175 commits
Select commit Hold shift + click to select a range
f3faca4
Added ECM + split OCV model
parkec3 Aug 9, 2024
80428c9
Merge branch 'pybamm-team:develop' into ocvr_ecm
parkec3 Aug 9, 2024
f93e67b
pre-commit changes
parkec3 Aug 9, 2024
83239a3
style: pre-commit fixes
pre-commit-ci[bot] Aug 9, 2024
2a945f2
Added parameter objects in model
parkec3 Aug 12, 2024
3bc77c2
Merged remote into local changes
parkec3 Aug 12, 2024
dbeaeb5
still working
parkec3 Aug 13, 2024
a502d17
Merge branch 'pybamm-team:develop' into ocvr_ecm
parkec3 Aug 14, 2024
3daabce
parameter updates
parkec3 Aug 14, 2024
1fc5670
Merge branch 'pybamm-team:develop' into ocvr_ecm
parkec3 Aug 16, 2024
758175f
added tests
parkec3 Aug 16, 2024
99e3119
style: pre-commit fixes
pre-commit-ci[bot] Aug 16, 2024
b1de9d1
pre-commit
parkec3 Aug 16, 2024
84fba69
Merge branch 'ocvr_ecm' of https://github.com/parkec3/PyBaMM into ocv…
parkec3 Aug 16, 2024
3f1e7f5
added default plotting variables
parkec3 Aug 20, 2024
b4c1897
Merge branch 'pybamm-team:develop' into ocvr_ecm
parkec3 Aug 20, 2024
e4504a6
added docs
parkec3 Aug 20, 2024
9a996c4
updated for pytest and better coverage
parkec3 Aug 21, 2024
4f7fed0
added phase-dependent particle to LAM
parkec3 Aug 21, 2024
0b0171f
adding tests, still debugging
parkec3 Aug 28, 2024
ae2be71
draft graded electrodes notebook
brosaplanella Aug 28, 2024
b820e59
Merge branch 'develop' into ocvr_ecm
kratman Aug 28, 2024
719823e
added more phase-dependent pars
parkec3 Aug 29, 2024
f23ac77
updated tests and naming convention
parkec3 Sep 3, 2024
13270c2
Merge branch 'develop' into ocvr_ecm
kratman Sep 3, 2024
41f02c2
Merge branch 'pybamm-team:develop' into LAM_phases
parkec3 Sep 3, 2024
2511707
Merge pull request #4410 from pybamm-team/main
kratman Sep 3, 2024
ac93806
Remove outdated reminders (#4409)
kratman Sep 3, 2024
4786443
Merge branch 'develop' into ocvr_ecm
kratman Sep 3, 2024
3b21bf6
Move changelog update to unreleased
kratman Sep 3, 2024
3898453
Update CHANGELOG.md to include surface thermal model (#4412)
valentinsulzer Sep 3, 2024
4241246
Build(deps): bump the actions group across 1 directory with 3 updates…
dependabot[bot] Sep 4, 2024
b073fc7
Remove unnecessary `dt` checks (#4416)
MarcBerliner Sep 4, 2024
1851d9f
Merge branch 'pybamm-team:develop' into LAM_phases
parkec3 Sep 5, 2024
d01dd80
fixed phase volume fraction for reaction-driven
parkec3 Sep 5, 2024
d33d3bc
Total SEI thickness calculation added
parkec3 Sep 6, 2024
613230c
Renames `set_events` to `add_events_from` (#4421)
medha-14 Sep 6, 2024
ee325c7
docs: add medha-14 as a contributor for code (#4423)
allcontributors[bot] Sep 6, 2024
63e30d4
Updated tests to fix testing errors for new pars
parkec3 Sep 6, 2024
fb7fe35
added reaction-driven composite test
parkec3 Sep 6, 2024
d0c9ded
add graded electrodes example
brosaplanella Sep 7, 2024
d43142b
Merge branch 'develop' into graded-electrode-example
brosaplanella Sep 7, 2024
f28e687
add graded electrode notebook to index
brosaplanella Sep 7, 2024
b3aeaf1
Merge branch 'graded-electrode-example' of github.com:pybamm-team/PyB…
brosaplanella Sep 7, 2024
6c1815b
Merge pull request #4424 from pybamm-team/graded-electrode-example
valentinsulzer Sep 7, 2024
712a3ee
Merge branch 'develop' into ocvr_ecm
valentinsulzer Sep 7, 2024
10a2254
#4405 make dUdT and volume change functions of sto only (#4427)
rtimms Sep 9, 2024
0cc6f72
allow tol and inputs to be passes to get_initial_ocps (#4426)
rtimms Sep 9, 2024
1d94c3e
Updated tests, citatation for LAM phase
parkec3 Sep 9, 2024
fcbe756
chore: update pre-commit hooks (#4430)
pre-commit-ci[bot] Sep 9, 2024
b9e7d10
updated the LAM notebook and changelog
parkec3 Sep 10, 2024
80ef611
Merge branch 'develop' into LAM_phases
parkec3 Sep 10, 2024
361b094
updating to develop branch
parkec3 Sep 10, 2024
af601b1
Merge branch 'LAM_phases' of https://github.com/parkec3/PyBaMM into L…
parkec3 Sep 10, 2024
a43ab16
style: pre-commit fixes
pre-commit-ci[bot] Sep 10, 2024
7449d5d
precommit
parkec3 Sep 10, 2024
20c80b8
Merge branch 'LAM_phases' of https://github.com/parkec3/PyBaMM into L…
parkec3 Sep 10, 2024
6a8e339
fixed phase and domain thickness calcs
parkec3 Sep 11, 2024
7f263e4
Merge pull request #4369 from parkec3/LAM_phases
DrSOKane Sep 11, 2024
c2d8ac2
Migrating unittest to pytest 6 (#4354)
prady0t Sep 13, 2024
ba2aa67
Migrating unittest to pytest (Part 7) (#4431)
prady0t Sep 13, 2024
35bcb78
feat: support sensitivities for pybamm.Simulation and pybamm.Experime…
martinjrobins Sep 13, 2024
343cea4
change check_extrapolation to use t/y_event
pipliggins Sep 13, 2024
d6b213c
style: pre-commit fixes
pre-commit-ci[bot] Sep 13, 2024
6888833
add basic telemetry
valentinsulzer Sep 15, 2024
a643c7b
add posthog dependency
valentinsulzer Sep 15, 2024
c644876
ignore posthog url
valentinsulzer Sep 15, 2024
84a8a87
changelog
valentinsulzer Sep 15, 2024
cb2d075
use uuid to identify individual users
valentinsulzer Sep 15, 2024
a76aff7
reordering
valentinsulzer Sep 15, 2024
4bf6d80
add case where config is not found
valentinsulzer Sep 15, 2024
f7ec885
agriya comments and coverage
valentinsulzer Sep 16, 2024
abac35f
more no cover
valentinsulzer Sep 16, 2024
8e3eb31
Build(deps): bump github/codeql-action in the actions group (#4444)
dependabot[bot] Sep 16, 2024
05a0b24
chore: update pre-commit hooks (#4445)
pre-commit-ci[bot] Sep 16, 2024
f47c12e
Merge branch 'develop' into output_vars_extrapolation
pipliggins Sep 17, 2024
e1118ec
Update CODEOWNERS (#4452)
MarcBerliner Sep 18, 2024
48dbb68
feat: add OpenMP parallelization to IDAKLU solver for lists of input …
martinjrobins Sep 18, 2024
5bb146f
Merge branch 'develop' into ocvr_ecm
valentinsulzer Sep 19, 2024
4cda488
Merge pull request #4330 from parkec3/ocvr_ecm
valentinsulzer Sep 19, 2024
06d7ecc
Merge branch 'develop' into output_vars_extrapolation
pipliggins Sep 19, 2024
37c94f9
Add test
pipliggins Sep 19, 2024
cee2cad
update changelog
pipliggins Sep 19, 2024
7be637c
Faster (re)initialization of ODEs in `IDA` (#4453)
MarcBerliner Sep 19, 2024
b012684
Switch test to triggered event
pipliggins Sep 20, 2024
f5717ff
Merge branch 'develop' into output_vars_extrapolation
MarcBerliner Sep 20, 2024
d362c98
Merge pull request #4440 from pipliggins/output_vars_extrapolation
MarcBerliner Sep 20, 2024
18ef2b2
Build(deps): bump github/codeql-action in the actions group (#4460)
dependabot[bot] Sep 23, 2024
1b6ef03
chore: update pre-commit hooks (#4461)
pre-commit-ci[bot] Sep 23, 2024
e148006
Added __iter__ and __contains__ method to pybamm.ParameterValues (#4465)
AbhishekChaudharii Sep 25, 2024
ffad85c
docs: add AbhishekChaudharii as a contributor for test (#4467)
allcontributors[bot] Sep 25, 2024
1390ea3
Remove chemistry dep warning (#4466)
kratman Sep 25, 2024
62a7ee8
perf: refactor and speed-ups for Jax BDF Solver (#4456)
BradyPlanden Sep 26, 2024
ad0faa1
merge develop, remove autoinstall
valentinsulzer Sep 26, 2024
b6fa67a
Final pytest migration (#4443)
prady0t Sep 28, 2024
78c2410
Removing all instances of unittest (#4472)
prady0t Oct 1, 2024
5913154
Require setuptools for citations (#4478)
kratman Oct 1, 2024
5cf68bd
chore: update pre-commit hooks (#4476)
pre-commit-ci[bot] Oct 1, 2024
08e5cf2
Build(deps): bump github/codeql-action in the actions group (#4474)
dependabot[bot] Oct 1, 2024
444ecc1
Fast Hermite interpolation and observables (#4464)
MarcBerliner Oct 2, 2024
025b019
merge develop
valentinsulzer Oct 3, 2024
a41d3ab
update telemetry to opt-in
valentinsulzer Oct 3, 2024
3939e7f
remove duplicate test
valentinsulzer Oct 3, 2024
b8f588b
coverage
valentinsulzer Oct 3, 2024
2ca16ac
Fix a type issue for windows (#4486)
kratman Oct 3, 2024
2e222c6
implement timeout
valentinsulzer Oct 5, 2024
bc53572
Merge branch 'develop' into telemetry
valentinsulzer Oct 6, 2024
9751574
Fix doc failures in notebooks (#4498)
kratman Oct 7, 2024
a7d476e
Implement sodium-ion DFN (#4451)
brosaplanella Oct 7, 2024
0636e94
Build(deps): bump the actions group with 3 updates (#4499)
dependabot[bot] Oct 7, 2024
9e62b66
chore: update pre-commit hooks (#4500)
pre-commit-ci[bot] Oct 7, 2024
e4eb82a
feat: add discrete time sum expression tree node (#4501)
martinjrobins Oct 9, 2024
0efe5f6
Removes `param = self.param` to use `self.param` directly (#4494)
medha-14 Oct 10, 2024
ab0020a
More accurate `QuickPlot`s with Hermite interpolation (#4483)
MarcBerliner Oct 10, 2024
7ea74f3
Adds doc strings for attributes in `base_model` and `base_submodel` (…
medha-14 Oct 10, 2024
a34ff4e
Merge branch 'develop' into telemetry
valentinsulzer Oct 11, 2024
41ca5f6
docs: add MarcBerliner as a contributor for code, doc, and infra (#4505)
allcontributors[bot] Oct 11, 2024
974b10a
docs: add MarcBerliner as a contributor for maintenance (#4506)
allcontributors[bot] Oct 11, 2024
3bf3ea8
Fix Jax links (#4504)
kratman Oct 11, 2024
aa9a66e
Merge branch 'develop' into telemetry
kratman Oct 11, 2024
d48f8c6
Update src/pybamm/config.py
valentinsulzer Oct 12, 2024
3ee7dd0
refactor: use pytest fixtures to reduce repetition in tests (#4509)
Aswinr24 Oct 13, 2024
96d52e6
docs: add Aswinr24 as a contributor for test (#4511)
allcontributors[bot] Oct 14, 2024
f14ebed
Build(deps): bump the actions group with 3 updates (#4513)
dependabot[bot] Oct 14, 2024
e5be8a5
chore: update pre-commit hooks (#4515)
pre-commit-ci[bot] Oct 14, 2024
9eb4bc7
Replacing setUp fixture with setup_method (#4514)
prady0t Oct 15, 2024
47c165d
Add "voltage as a state" option (#4507)
rtimms Oct 15, 2024
fb81f21
Add _from_json functionality for pybamm.sign (#4517)
pipliggins Oct 15, 2024
82f7a0f
Removing the macos-12 runner (#4520)
kratman Oct 17, 2024
815bf91
10 second timeout
valentinsulzer Oct 18, 2024
47311e6
Merge branch 'telemetry' of github.com:pybamm-team/PyBaMM into telemetry
valentinsulzer Oct 18, 2024
fd567d2
Merge branch 'develop' into telemetry
valentinsulzer Oct 18, 2024
8d1e192
don't use inputimeout
valentinsulzer Oct 18, 2024
e52a406
Fix CasADI path and disable IREE for MacOS (#4528)
kratman Oct 18, 2024
1a835a4
Merge branch 'develop' into telemetry
kratman Oct 18, 2024
208ae11
docs: update param values notebook (#4531)
martinjrobins Oct 21, 2024
ed2bfec
docs: add input parameters to getting started docs (#4533)
martinjrobins Oct 21, 2024
f20a00e
chore: update pre-commit hooks (#4537)
pre-commit-ci[bot] Oct 21, 2024
164f71e
docs: describe public api in front-page of API docs (#4536)
martinjrobins Oct 22, 2024
9560875
Fix indexing bug with infeasible experiments for `IDAKLUSolver` (#4541)
MarcBerliner Oct 23, 2024
3864e5d
Allow using IDAKLU(output_variables=...) with Experiments (#4534)
pipliggins Oct 28, 2024
75d403d
Merge branch 'develop' into telemetry
valentinsulzer Oct 28, 2024
1bf5b89
add more tests for config
valentinsulzer Oct 28, 2024
aa74cfe
Build(deps): bump github/codeql-action in the actions group (#4548)
dependabot[bot] Oct 28, 2024
01a7c08
chore: update pre-commit hooks (#4549)
pre-commit-ci[bot] Oct 28, 2024
7df73c4
Merge branch 'develop' into telemetry
valentinsulzer Oct 30, 2024
b9b721f
add coupled variable to expression tree and discretisation
aabills Oct 31, 2024
f307491
add test; add coupledvariable dict to model
aabills Oct 31, 2024
65a45af
style: pre-commit fixes
pre-commit-ci[bot] Oct 31, 2024
4d638c9
pre-commit
aabills Oct 31, 2024
0d4f12d
Trigger CI
aabills Oct 31, 2024
c259bb0
add tests for coverage; valentin comments
aabills Oct 31, 2024
19a7738
Merge pull request #4556 from aabills/coupled-variable-2
valentinsulzer Nov 4, 2024
969a879
Using `tempfile` for test_symbol_visualise to remove flaky test. (#4544)
prady0t Nov 4, 2024
106c249
chore: update pre-commit hooks (#4564)
pre-commit-ci[bot] Nov 4, 2024
f4e4955
add reaction heating (#4557)
aabills Nov 4, 2024
b0382e6
Cleanup formatting in error messages (#4565)
kratman Nov 5, 2024
4a50562
docs: add sensitivities notebook (#4559)
martinjrobins Nov 5, 2024
9a479cf
Make ParameterValues.pop return a value (#4571)
kratman Nov 6, 2024
f05cae2
bug: use direct casadi bspline function for 1D & 2D cubic interp (#4572)
martinjrobins Nov 7, 2024
215252b
Merge branch 'develop' into telemetry
valentinsulzer Nov 7, 2024
0183250
coverage
valentinsulzer Nov 7, 2024
0e0936a
Build(deps): bump the actions group with 2 updates (#4574)
dependabot[bot] Nov 11, 2024
9ac0b5b
chore: update pre-commit hooks (#4575)
pre-commit-ci[bot] Nov 11, 2024
1022c6b
Merge branch 'develop' into telemetry
valentinsulzer Nov 12, 2024
0eae1a4
Merge pull request #4441 from pybamm-team/telemetry
valentinsulzer Nov 12, 2024
bf8f623
Misc. bug fixes (#4581)
kratman Nov 12, 2024
cb50363
Throw an error when concatenations have different number of children …
aabills Nov 12, 2024
4223be8
Update baseline for CasADi 3.6.7 bump (#4582)
agriyakhetarpal Nov 13, 2024
bcdd0b5
allow tol in initial voltage for setting stoichiometries (#4586)
rtimms Nov 14, 2024
36f8833
Build(deps): bump the actions group with 2 updates (#4592)
dependabot[bot] Nov 18, 2024
6dfa38e
chore: update pre-commit hooks (#4593)
pre-commit-ci[bot] Nov 18, 2024
e17b549
[Bug]: `pybamm.Simulation.set_parameters` and `pybamm.Simulation.set_…
Akhil-Sharma30 Nov 19, 2024
6c7c21a
Fix telemetry issues in wheel build and unit tests (#4591)
kratman Nov 19, 2024
97a37fd
Release 24.11.0
kratman Nov 20, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add reaction heating (#4557)
* add reaction heating

* style: pre-commit fixes

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Eric G. Kratz <kratman@users.noreply.github.com>
3 people authored Nov 4, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
commit f4e4955e41932faacde6394de98f92646e036cfc
8 changes: 6 additions & 2 deletions src/pybamm/models/submodels/thermal/base_thermal.py
Original file line number Diff line number Diff line change
@@ -143,8 +143,12 @@ def _get_standard_coupled_variables(self, variables):
phase_names = ["primary ", "secondary "]

if self.options.electrode_types["negative"] == "planar":
Q_rxn_n = pybamm.FullBroadcast(
0, ["negative electrode"], "current collector"
i_n = variables["Lithium metal total interfacial current density [A.m-2]"]
eta_r_n = variables["Lithium metal interface reaction overpotential [V]"]
Q_rxn_n = pybamm.PrimaryBroadcast(
i_n * eta_r_n / self.param.n.L,
["negative electrode"],
"current collector",
)
Q_rev_n = pybamm.FullBroadcast(
0, ["negative electrode"], "current collector"