Allow using IDAKLU(output_variables=...) with Experiments #4534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n copies during an Experiment Don't compute 'Change in x' summary variables if output_variables are specified
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4534 +/- ##
========================================
Coverage 99.42% 99.42%
========================================
Files 299 299
Lines 22716 22736 +20
========================================
+ Hits 22585 22605 +20
Misses 131 131 ☔ View full report in Codecov by Sentry. |
…used Remove warnings about 'Change in x' summary variables
pipliggins
requested review from
martinjrobins,
rtimms,
valentinsulzer,
TomTranter and
MarcBerliner
as code owners
MarcBerliner
requested changes
Oct 23, 2024
There was a problem hiding this comment.
Looks good @pipliggins, just a few minor changes. The changelog needs updating as well
6 tasks
Indicates if 'output_variables' are specified in solver and therefore empty state vector
MarcBerliner
approved these changes
Oct 28, 2024
pkalbhor
pushed a commit
to pkalbhor/PyBaMM
that referenced
this pull request
Nov 15, 2024
…m#4534) * Add test for idaklu+output_variables+experiment * edit Solution.last_state to pull y_event if all_ys is empty * Ensure ProcessedVariableComputed variables are passed through Solution copies during an Experiment Don't compute 'Change in x' summary variables if output_variables are specified * populate first_state using the initial condition if output_variables used Remove warnings about 'Change in x' summary variables * Add to computed processed variable tests * Add test for solution::add with computed variables * add test for solution::copy with computed variables * add check for idaklu on copy test * Add 'variables_returned' attribute to Solution Indicates if 'output_variables' are specified in solver and therefore empty state vector * Use `variables_returned` in `_update_variable()`, update test * Update CHANGELOG * Add test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allows users to use the
output_variablesoption with the IDAKLU solver within an experiment.Fixes #4386
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ pre-commit run(or$ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)$ python run-tests.py --all(or$ nox -s tests)$ python run-tests.py --doctest(or$ nox -s doctests)You can run integration tests, unit tests, and doctests together at once, using
$ python run-tests.py --quick(or$ nox -s quick).Further checks: