-
-
Notifications
You must be signed in to change notification settings - Fork 553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Renames set_events
to add_events_from
#4421
Conversation
set_events
to add_events_from
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4421 +/- ##
========================================
Coverage 99.41% 99.41%
========================================
Files 292 292
Lines 22212 22212
========================================
Hits 22083 22083
Misses 129 129 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like you might have missed reaction_driven_porosity.py
when doing these changes. Can you double check that one?
b227416
to
9687f8c
Compare
Sorry I missed it. |
Thank you, just update the changelog and it should be good to go. Put this one under "breaking changes" in the unreleased section since it is renaming a function. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks looks good
@all-contributors please add @medha-14 for code |
I've put up a pull request to add @medha-14! 🎉 |
Thank you, @kratman, for the review. This was my first PR, and I look forward to contributing more to Pybamm. |
Description
I have renamed
set_events
toadd_events_from
in all occurrencesFixes #4266
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ pre-commit run
(or$ nox -s pre-commit
) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)$ python run-tests.py --doctest
(or$ nox -s doctests
)