Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renames set_events to add_events_from #4421

Merged
merged 6 commits into from
Sep 6, 2024

Conversation

medha-14
Copy link
Contributor

@medha-14 medha-14 commented Sep 6, 2024

Description

I have renamed set_events to add_events_from in all occurrences

Fixes #4266

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ pre-commit run (or $ nox -s pre-commit) (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
  • All relevant tests pass, except latxeify which are unrelated.
  • The documentation builds: $ python run-tests.py --doctest (or $ nox -s doctests)

@medha-14 medha-14 changed the title Rename set_eventschanged set_events to add_events_from Renames set_events to add_events_from Sep 6, 2024
Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.41%. Comparing base (b073fc7) to head (4f72bcd).
Report is 204 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #4421   +/-   ##
========================================
  Coverage    99.41%   99.41%           
========================================
  Files          292      292           
  Lines        22212    22212           
========================================
  Hits         22083    22083           
  Misses         129      129           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@kratman kratman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like you might have missed reaction_driven_porosity.py when doing these changes. Can you double check that one?

@medha-14
Copy link
Contributor Author

medha-14 commented Sep 6, 2024

It looks like you might have missed reaction_driven_porosity.py when doing these changes. Can you double check that one?

Sorry I missed it.

@kratman
Copy link
Contributor

kratman commented Sep 6, 2024

Thank you, just update the changelog and it should be good to go. Put this one under "breaking changes" in the unreleased section since it is renaming a function.

@medha-14 medha-14 requested a review from kratman September 6, 2024 17:56
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Contributor

@kratman kratman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks looks good

@agriyakhetarpal
Copy link
Member

@all-contributors please add @medha-14 for code

Copy link
Contributor

@agriyakhetarpal

I've put up a pull request to add @medha-14! 🎉

@kratman kratman merged commit 613230c into pybamm-team:develop Sep 6, 2024
26 checks passed
@medha-14
Copy link
Contributor Author

medha-14 commented Sep 6, 2024

Thank you, @kratman, for the review. This was my first PR, and I look forward to contributing more to Pybamm.

@medha-14 medha-14 deleted the set_events_rename branch October 11, 2024 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename set_events
3 participants